Add getTimeout() call to ATParser. Add payload for RX callback in BufferedSerial. #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the way the ringbuffer works it's not possible to get the underlying buffer in the RX IRQ callback because then ATParser will miss characters. By adding the character as a parameter to the RX callback you can get the data in the callback, and ATParser will not miss anything (because you can implement another independent buffer).
@geky @sarahmarshy