Tegra: Fix assert on mapping memory regions #1269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tegra memory controller driver uses the "xlat_tables_v2.h" include. See: plat/nvidia/tegra/common/drivers/memctrl/memctrl_v1.c plat/nvidia/tegra/common/drivers/memctrl/memctrl_v2.c But other tegra specific parts use "xlat_tables.h". Use the same include in common tegra code. This fixes: ERROR: mmap_add_region_check() failed. error -22 ASSERT: lib/xlat_tables_v2/xlat_tables_internal.c:752:0 Signed-off-by: Andre Heider <a.heider@gmail.com>
|
Can one of the admins verify this patch? |
vwadekar
approved these changes
Feb 15, 2018
|
Just seeing this now - I submitted #1271, which covers t132 and t186, too. |
|
jenkins: test this please |
|
@davidcunado-arm So, are you planning to merge this one? Then at least the commit message should be amended to refer to the issue I opened. I would then need to rebase my pull onto this one to cover the missing parts. |
|
@afaerber |
|
@afaerber's patch is more complete, so all good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tegra memory controller driver uses the "xlat_tables_v2.h" include.
See:
plat/nvidia/tegra/common/drivers/memctrl/memctrl_v1.c
plat/nvidia/tegra/common/drivers/memctrl/memctrl_v2.c
But other tegra specific parts use "xlat_tables.h".
Use the same include in common tegra code.
This fixes:
ERROR: mmap_add_region_check() failed. error -22
ASSERT: lib/xlat_tables_v2/xlat_tables_internal.c:752:0
Signed-off-by: Andre Heider a.heider@gmail.com