Allow build with ITK 5.3 #1279
Merged
Allow build with ITK 5.3 #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @hjmjohnson . Is this ready to merge despite the failing check? |
ITK 5.3 and greater requires features and bug fixes introduced with C++14 and greater. Allow ANTs to bulid with newer versions of ITK if requested.
Inadvertently reverted in previous commit: The .h files include the .hxx files, which in turn include the original .h file. Remove the recursive includes.
hjmjohnson
force-pushed
the
allow-build-with-itk5.3
branch
from
e61e510
to
8381c45
Compare
|
@ntustison I think this is ready for merging now. The failure is "context deadline exceeded" due to taking longer than 60 minutes to run. |
|
Awesome. Thanks @hjmjohnson . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ITK 5.3 has updated cmake and C++ standard minimum requirements. Update to match the newest ITK minimum requirements.