Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trampoline info to auditDB #1767

Merged
merged 6 commits into from
Apr 15, 2021
Merged

Add trampoline info to auditDB #1767

merged 6 commits into from
Apr 15, 2021

Conversation

thomash-acinq
Copy link
Member

Add two columns for the recipient and amount sent to the recipient in case of trampoline relaying.
When using trampoline, the recipient may not be the next node on the path.

Add two columns for the recipient and amount sent to the recipient in case of trampoline relaying.
When using trampoline, the recipient may not be the next node on the path.
@codecov-io
Copy link

codecov-io commented Apr 14, 2021

Codecov Report

Merging #1767 (8e71ec2) into master (357f7f9) will decrease coverage by 0.04%.
The diff coverage is 87.09%.

@@            Coverage Diff             @@
##           master    #1767      +/-   ##
==========================================
- Coverage   89.28%   89.23%   -0.05%     
==========================================
  Files         144      144              
  Lines       10822    10880      +58     
  Branches      494      465      -29     
==========================================
+ Hits         9662     9709      +47     
- Misses       1160     1171      +11     
Impacted Files Coverage Δ
...main/scala/fr/acinq/eclair/db/DbEventHandler.scala 90.32% <ø> (ø)
.../scala/fr/acinq/eclair/payment/PaymentEvents.scala 97.61% <ø> (ø)
...c/main/scala/fr/acinq/eclair/db/pg/PgAuditDb.scala 96.38% <78.57%> (-2.60%) ⬇️
...cala/fr/acinq/eclair/db/sqlite/SqliteAuditDb.scala 97.95% <93.93%> (-1.12%) ⬇️
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala 94.02% <100.00%> (ø)
...c/main/scala/fr/acinq/eclair/channel/Channel.scala 86.45% <0.00%> (-0.23%) ⬇️
...main/scala/fr/acinq/eclair/io/PeerConnection.scala 85.10% <0.00%> (+0.42%) ⬆️

Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a few nits.
@pm47 has been working on the DB recently, let's wait to see for his review as well.

Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thomash-acinq thomash-acinq merged commit 15ddc17 into master Apr 15, 2021
@thomash-acinq thomash-acinq deleted the audit branch April 15, 2021 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants