Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move fee provider conf #1631

Merged
merged 2 commits into from
Dec 14, 2020
Merged

Move fee provider conf #1631

merged 2 commits into from
Dec 14, 2020

Conversation

pm47
Copy link
Member

@pm47 pm47 commented Dec 14, 2020

Took the opportunity to improve the naming as well.

I also considered putting them under a providers section, WDYT?

on-chain-fees {
  providers {
    min-feerate = 1 // minimum feerate in satoshis per byte
    smoothing-window = 6 // 1 = no smoothing
    timeout = 5 seconds // max time we'll wait for answers from a fee provider before we fallback to the next one
  }
...
}

This only affects the value returned by fee providers, it is
overriden by the other bitcoin-core enforced minimum (currently 253
sat/kiloweight).
@pm47 pm47 requested a review from t-bast December 14, 2020 15:18
Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I don't think we need to add a providers section, since we'll eventually get rid of providers like bitgo and earndotcom and instead only use bitcoin core.

@pm47 pm47 merged commit e8b47e1 into master Dec 14, 2020
@pm47 pm47 deleted the move-fee-provider-conf branch December 14, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants