Rework features compatibility #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `supportedMandatoryFeatures` set made less and less sense as we start supporting more features and allowing users to turn features on and off depending on the peers they connect to.
pm47
reviewed
Oct 22, 2020
pm47
approved these changes
Oct 22, 2020
Codecov Report
@@ Coverage Diff @@
## master #1576 +/- ##
==========================================
- Coverage 87.31% 87.28% -0.04%
==========================================
Files 139 139
Lines 10928 10923 -5
Branches 456 455 -1
==========================================
- Hits 9542 9534 -8
- Misses 1386 1389 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
supportedMandatoryFeaturesset made less and less sense as we start supporting more features and allowing users to turn features on and off depending on the peers they connect to.