Some more Multiversus support #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4sval
reviewed
Jul 29, 2022
| @@ -43,13 +43,13 @@ protected UCreator(UObject uObject, EIconStyle style) | |||
| protected readonly SKPaint DisplayNamePaint = new() | |||
| { | |||
| IsAntialias = true, FilterQuality = SKFilterQuality.High, | |||
| Typeface = Utils.Typefaces.DisplayName, TextSize = _NAME_TEXT_SIZE, | |||
| Typeface = Utils.Typefaces.DisplayName ?? Utils.Typefaces.Default, TextSize = _NAME_TEXT_SIZE, | |||
There was a problem hiding this comment.
You already set all of those to Default in Typefaces.cs
There was a problem hiding this comment.
Ah yeah. Before I added the specific typefaces for Multiversus, it crashed because of the DisplayName and Description typefaces being null so I just put that. Might be good to keep that check for games that don't have their own typefaces implemented yet
There was a problem hiding this comment.
I think it can be done directly in Typeface.cs
Actually that file needs a rework, especially to use OnTheFly more often
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main additions are icons for characters and skins. It could be added onto, but I'll eventually get around to making a cleaner looking Community icon for it.