-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: offline load data & show table status #3349
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
batch-engine
openmldb batch(offline) engine
storage-engine
openmldb storage engine. nameserver & tablet
labels
Jul 10, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3349 +/- ##
=============================================
+ Coverage 37.27% 53.03% +15.76%
=============================================
Files 177 2 -175
Lines 10238 181 -10057
Branches 1189 0 -1189
=============================================
- Hits 3816 96 -3720
+ Misses 6181 69 -6112
+ Partials 241 16 -225 ☔ View full report in Codecov by Sentry. |
aceforeverd
reviewed
Jul 10, 2023
vagetablechicken
requested review from
aceforeverd,
tobegit3hub,
dl239 and
lqy222
July 11, 2023 10:27
dl239
approved these changes
Jul 11, 2023
tobegit3hub
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
batch-engine
openmldb batch(offline) engine
documentation
Improvements or additions to documentation
storage-engine
openmldb storage engine. nameserver & tablet
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3342 and hive load fix