Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support alter table #3323

Merged
merged 11 commits into from
Jun 28, 2023

Conversation

tobegit3hub
Copy link
Collaborator

@tobegit3hub tobegit3hub commented Jun 16, 2023

  • Support add symbolic path.
  • Support drop symbolic path.

These are the simple cases to test.

create database if not exists db;

create table if not exists db.t1 (name string);

alter table db.t1 add offline_path 'hdfs://foo/bar';

alter table db.t1 drop offline_path 'hdfs://foo/bar';

alter table db.t1 add offline_path 'hdfs://foo/bar';

alter table db.t1 drop offline_path 'hdfs://foo/bar', add offline_path 'hdfs://foo/bar2';

desc db.t1;

@tobegit3hub tobegit3hub self-assigned this Jun 16, 2023
@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jun 16, 2023
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.13 🎉

Comparison is base (eb14873) 75.50% compared to head (21d87a6) 75.64%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3323      +/-   ##
============================================
+ Coverage     75.50%   75.64%   +0.13%     
  Complexity      414      414              
============================================
  Files           693      692       -1     
  Lines        126088   125870     -218     
  Branches       1189     1189              
============================================
+ Hits          95206    95212       +6     
+ Misses        30641    30417     -224     
  Partials        241      241              
Impacted Files Coverage Δ
src/sdk/sql_cluster_router.cc 61.29% <0.00%> (-1.13%) ⬇️

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 19, 2023
@tobegit3hub tobegit3hub merged commit 6bb5748 into 4paradigm:main Jun 28, 2023
23 of 24 checks passed
dl239 pushed a commit that referenced this pull request Jun 29, 2023
* Support add symbolic path

* Support drop symbolic path

* Refine code for format

* Resolve cpplint

* Update docs

* Add ut for alter table

* Remove debug code

* Fix syntax error

* Add multi thread ut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants