Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

batch: compile warning that check a long for null #1408

Closed
vagetablechicken opened this issue Mar 10, 2022 · 2 comments · Fixed by #1870
Closed

batch: compile warning that check a long for null #1408

vagetablechicken opened this issue Mar 10, 2022 · 2 comments · Fixed by #1870
Assignees
@Ivyee17
Labels
good first issue Good for newcomers

Comments

@vagetablechicken
Copy link
Collaborator

vagetablechicken commented Mar 10, 2022 •
edited
Loading 

[WARNING] /Users/tobe/code/4pd/OpenMLDB/java/openmldb-batch/src/main/scala/com/_4paradigm/openmldb/batch/nodes/WindowAggPlan.scala:530: warning: com
paring values of types Long and Null using `==' will always yield false
[WARNING]     if (key == null) {
[WARNING]             ^

You can reproduce the issue by compiling java modules with mvn clean package.
@vagetablechicken vagetablechicken added the good first issue Good for newcomers label Mar 10, 2022
@dl239 dl239 mentioned this issue Mar 10, 2022
Closed
@lumianph
Copy link
Collaborator

this issue belongs to our Contributor Challenges program, you can redeem your rewards after your PR is merged.
#1344

@lumianph lumianph mentioned this issue May 10, 2022
Closed
@Cupid0320 Cupid0320 mentioned this issue May 11, 2022
Open
@Ivyee17
Copy link
Contributor

Ivyee17 commented May 20, 2022 •
edited
Loading

I want to help this!WeOpen Star

@Ivyee17 Ivyee17 mentioned this issue May 23, 2022
Merged
@vagetablechicken vagetablechicken mentioned this issue May 30, 2022
Open
vagetablechicken pushed a commit that referenced this issue May 30, 2022
@Ivyee17
fix: batch: compile warning that check a long for null #1408 (#1870)
18c21ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ivyee17 Ivyee17

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: batch: compile warning that check a long for null #1408 Ivyee17/OpenMLDB
3 participants
@lumianph @vagetablechicken @Ivyee17