[2.8] Do not recreate OIDCConf object from UI IntegrationsController #1838
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.8 patch for THREESCALE-5103
Verification steps
Follow these steps to test it locally.
config/rolling_updates.yml
(I think that only the 2nd one is necessary for this, but just in case):bundle exec rake webpack:dev
UNICORN_WORKERS=8 bundle exec rails server -b 0.0.0.0
bundle exec sidekiq -q default -L log/sidekiq.log
and runbundle exec rake fixes:create_missing_service_tokens
. Then you won't need sidekiq anymore for this so feel free to close it after this 😄http://provider-admin.example.com.lvh.me:3000/apiconfig/services/2/integration
,Edit authentication settings
and select the AuthenticationOpenID Connect
http://provider-admin.example.com.lvh.me:3000/apiconfig/services/2/integration
,add the base URL of your API and save the configuration
, scroll down toAuthentication Settings
, change the OIDC config, and click toUpdate
.bundle exec rails console
and check the OIDCConfig withProxy.find(2).oidc_configuration
. Ensure that it has the configuration that you saved and that it contains an ID.As a bonus, do
OIDCConfiguration.all
and see that there is only one.It is recommended to do these steps with this branch and also in a branch without these changes so you can see the difference.