Fix APIAP routing policy rule #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jsmadis will be good to add this case to the framework ;-) |
The regex used to match the path of the backend in the APIAP routing policy configuration should only allow paths that _start with_ the chosen value for the path. Currently it matches all paths that _contains_ the value. This fixes it by adding a `^` to the beginning of the pattern.
guicassolato
force-pushed
the
fix/apiap/routing-rule-starts-with
branch
from
f21917f
to
b9d6e10
Compare
Codecov Report
@@ Coverage Diff @@
## master #1777 +/- ##
=========================================
Coverage ? 93.06%
=========================================
Files ? 2511
Lines ? 83390
Branches ? 0
=========================================
Hits ? 77611
Misses ? 5779
Partials ? 0
Continue to review full report at Codecov.
|
Martouta
approved these changes
Mar 27, 2020
thomasmaas
approved these changes
Mar 27, 2020
There was a problem hiding this comment.
Probably good candidate for 2.8.1 @guicassolato? If so, change target release.
hallelujah
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex used to match the path of the backend in the APIAP routing policy configuration should only allow paths that start with the chosen value for the path. Currently it matches all paths that contains the value.
This PR fixes it by wrapping the current regex pattern within a
^()group.Closes THREESCALE-4736