Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ionbox refactor #427

Draft
wants to merge 20 commits into
base: v4-prep
Choose a base branch
from
Draft

Ionbox refactor #427

wants to merge 20 commits into from

Conversation

daviesje
Copy link
Contributor

This is a coarse modularisation of the ionised box calculation which separates the large function into a number of smaller steps. This should make future development easier. I have tested that we get the same results under a few variations of parameters, and it has not slowed down.

Key differences:

  • constants are calculated at the beginning and held in a struct which is passed into each function.
  • Radii are explicitly calculated at the beginning of the run, instead of on-the-fly in a while loop
  • the RNG for partial ionisations has been explicitly removed (it only affected the !USE_MASS_DEPENDENT_ZETA case)

Further modularisation is possible, but best left to another PR

@daviesje daviesje linked an issue Sep 16, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor of ComputeIonizedBox
1 participant