Add on_reconnect callback on the async client
#405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Async clients that are using the reconnect feature can now provide an optional callback that will be invoked before the server is reconnected. You may optionally update the address or auth settings in this callback and they will be applied when the client reconnects. This is useful for updating auth tokens which may have expired by the time a reconnection is required.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #405 +/- ##
=======================================
Coverage 91.95% 91.95%
=======================================
Files 36 36
Lines 5007 5073 +66
=======================================
+ Hits 4604 4665 +61
- Misses 403 408 +5 ☔ View full report in Codecov by Sentry. |
rageshkrishna
force-pushed
the
feat/401-reconnect-auth
branch
from
2f05dea
to
57a2752
Compare
rageshkrishna
force-pushed
the
feat/401-reconnect-auth
branch
from
57a2752
to
f7df753
Compare
|
Hi @1c3t3a! Just checking if you had a chance to look at this. Let me know if you need any changes. Thanks. |
1c3t3a
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Async clients that are using the reconnect feature can now provide an optional callback that will be invoked before the server is reconnected. You may optionally update the address or auth settings in this callback and they will be applied when the client reconnects.
This is useful for updating auth tokens which may have expired by the time a reconnection is required.
Fixes #401