Small changes #689
Small changes #689
Conversation
|
@stevestriker is attempting to deploy a commit to the 1hive Team on Vercel. A member of the Team first needs to authorize it. |
| @@ -1,4 +1,5 @@ | |||
| import React, { useEffect, useState } from 'react' | |||
| import { Link } from 'react-router-dom' | |||
There was a problem hiding this comment.
As discussed on Discord, let´s use the Link component from @1hive/1hive-ui.
There was a problem hiding this comment.
You an see an example here
| <EthIdenticon address={proposal.creator} radius={50} scale={1.8} /> | ||
| )} | ||
| </div> | ||
| <Link to={`/profile?account=${proposal.creator}`}> |
There was a problem hiding this comment.
With the previous comment, this should be now
| <Link to={`/profile?account=${proposal.creator}`}> | |
| <Link href={`/profile?account=${proposal.creator}`} external={false}> |
| border-radius: 50%; | ||
| display: block; | ||
| object-fit: cover; | ||
| cursor: pointer; |
There was a problem hiding this comment.
Using the Link component suggested we don´t need to set this style
| cursor: pointer; |
| radius={50} | ||
| scale={1.8} | ||
| css={` | ||
| cursor: pointer; |
| <FixedFooter /> | ||
| ) : ( | ||
| <Layout paddingBottom={70}> | ||
| <FixedFooter /> |
There was a problem hiding this comment.
Why did we remove the compactMode condition? Note that we only want the Fixed Footer on smaller screen sizes
There was a problem hiding this comment.
Removed cursor:pointer.
Fixed the href properties to direct correctly.
Still need to configure the compact mode footer tooldbar.
Per request, added the underline to the proposal and removed the underline from the eth-address of the creator