Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove otherwise redefinition to fix incomplete patterns warning #46

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Remove otherwise redefinition to fix incomplete patterns warning #46

merged 1 commit into from
Mar 1, 2022

Conversation

JuanFdS
Copy link
Collaborator

@JuanFdS JuanFdS commented Mar 1, 2022

Another way to solve this issue: #45

@JuanFdS JuanFdS mentioned this pull request Mar 1, 2022
Closed
@JuanFdS JuanFdS requested review from fdodino and ludat March 1, 2022 21:47
ludat
ludat approved these changes Mar 1, 2022
View reviewed changes
src/Redefinitions.hs
-- @
otherwise :: Bool
otherwise = P.otherwise

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jajajaj encima ni siquiera lo estabamos traduciendo 😛

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jajaja el nombre de la función no, la documentación 😭

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah lastima que perdamos eso :F:

fdodino
fdodino approved these changes Mar 1, 2022
View reviewed changes
Copy link
Collaborator

@fdodino fdodino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Che, qué bueno que le encontraste la vuelta, yo había probado usando hasta True y me tiraba el warning de usar otherwise y ya no había forma.

💯 !!!

@JuanFdS JuanFdS merged commit 7c89e5d into master Mar 1, 2022
@JuanFdS JuanFdS deleted the fix-incomplete-pattern-warning-removing-otherwise-redefinition branch March 1, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludat ludat ludat approved these changes

@fdodino fdodino fdodino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JuanFdS @fdodino @ludat