[TECH] Ne pas permettre de faire de release Pix-UI sans donner de version #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anne-Gaelle-S
force-pushed
the
tech-fix-pix-ui-release
branch
from
4b13616
to
9f50eda
Compare
AndreiaPena
reviewed
Aug 27, 2021
Co-authored-by: Andreia Pena <58915422+AndreiaPena@users.noreply.github.com>
AndreiaPena
reviewed
Aug 27, 2021
| postSlackMessage(`[PIX-UI] App deployed (${releaseTagAfterRelease})`); | ||
| sendResponse(responseUrl, getSuccessMessage(releaseTagAfterRelease, repoName)); |
There was a problem hiding this comment.
Question : Pourquoi inverser ici ?
There was a problem hiding this comment.
parce que le message ne s'affiche pas, du coup c'est un peu un test, je soupsonne le sendResponse de "bloquer" l'envoie du message sur slack
AndreiaPena
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
1- Lorsqu'on tape /publish-pix-ui sur slack il est facile de se tromper et taper directement "entrée" en pensant qu'il va demander la version juste après.
Or actuellement Pix-Bot choisit par défaut la version minor, ce qui peut être contre-intuitif.
2- Aucun message publique ne s'affiche pour informer de la nouvelle version de Pix-UI (tout est écrit en "privé" à la personne qui fait la release). Or cela serait intéressant à but informatif de savoir s'il y a une nouvelle version de Pix-UI déployée.
🤖 Solution
💯 Pour tester