Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TECH] Mettre a jour le chemin de config.js #322

Merged
merged 1 commit into from
Sep 29, 2023
Merged

[TECH] Mettre a jour le chemin de config.js #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/services/github.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ async function _getCommitsWhereConfigFileHasChangedBetweenDate(repoOwner, repoNa
repo: repoName,
since: sinceDate,
until: untilDate,
path: 'api/lib/config.js',
path: 'api/src/shared/config.js',
});

return data;
Expand Down
4 changes: 3 additions & 1 deletion test/acceptance/build/slack_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,9 @@ describe('Acceptance | Build | Slack', function () {
/since=\d{4}-\d{2}-\d{2}T\d{2}%3A\d{2}%3A\d{2}.\d{3}Z&until=\d{4}-\d{2}-\d{2}T\d{2}%3A\d{2}%3A\d{2}.\d{3}Z/g,
'since=XXXX&until=XXXX',
)
.get('/repos/github-owner/github-repository/commits?since=XXXX&until=XXXX&path=api%2Flib%2Fconfig.js')
.get(
'/repos/github-owner/github-repository/commits?since=XXXX&until=XXXX&path=api%2Fsrc%2Fshared%2Fconfig.js',
)
.reply(200, [
{
sha: '6dcb09',
Expand Down
4 changes: 2 additions & 2 deletions test/test-helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ function nockGithubWithNoConfigChanges() {
/since=\d{4}-\d{2}-\d{2}T\d{2}%3A\d{2}%3A\d{2}.\d{3}Z&until=\d{4}-\d{2}-\d{2}T\d{2}%3A\d{2}%3A\d{2}.\d{3}Z/g,
'since=XXXX&until=XXXX',
)
.get('/repos/github-owner/github-repository/commits?since=XXXX&until=XXXX&path=api%2Flib%2Fconfig.js')
.get('/repos/github-owner/github-repository/commits?since=XXXX&until=XXXX&path=api%2Fsrc%2Fshared%2Fconfig.js')
.reply(200, []);

const nocks = { tags, commit1234, commit456, commits };
Expand Down Expand Up @@ -152,7 +152,7 @@ function nockGithubWithConfigChanges() {
/since=\d{4}-\d{2}-\d{2}T\d{2}%3A\d{2}%3A\d{2}.\d{3}Z&until=\d{4}-\d{2}-\d{2}T\d{2}%3A\d{2}%3A\d{2}.\d{3}Z/g,
'since=XXXX&until=XXXX',
)
.get('/repos/github-owner/github-repository/commits?since=XXXX&until=XXXX&path=api%2Flib%2Fconfig.js')
.get('/repos/github-owner/github-repository/commits?since=XXXX&until=XXXX&path=api%2Fsrc%2Fshared%2Fconfig.js')
.reply(200, [{}]);
}

Expand Down
8 changes: 4 additions & 4 deletions test/unit/build/services/github_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ describe('Unit | Build | github-test', function () {
];
nock('https://api.github.com')
.get('/repos/github-owner/github-repository/commits')
.query({ since: latestReleaseDate, until: now.toISOString(), path: 'api/lib/config.js' })
.query({ since: latestReleaseDate, until: now.toISOString(), path: 'api/src/shared/config.js' })
.reply(200, [
{
sha: '5ec2f42',
Expand Down Expand Up @@ -394,7 +394,7 @@ describe('Unit | Build | github-test', function () {
];
nock('https://api.github.com')
.get('/repos/github-owner/github-repository/commits')
.query({ since: latestReleaseDate, until: now.toISOString(), path: 'api/lib/config.js' })
.query({ since: latestReleaseDate, until: now.toISOString(), path: 'api/src/shared/config.js' })
.reply(200, []);

nock('https://api.github.com')
Expand Down Expand Up @@ -437,7 +437,7 @@ describe('Unit | Build | github-test', function () {
// given
nock('https://api.github.com')
.get('/repos/github-owner/github-repository/commits')
.query({ since: secondToLastReleaseDate, until: latestReleaseDate, path: 'api/lib/config.js' })
.query({ since: secondToLastReleaseDate, until: latestReleaseDate, path: 'api/src/shared/config.js' })
.reply(200, [
{
sha: '5ec2f42',
Expand Down Expand Up @@ -472,7 +472,7 @@ describe('Unit | Build | github-test', function () {
// given
nock('https://api.github.com')
.get('/repos/github-owner/github-repository/commits')
.query({ since: secondToLastReleaseDate, until: latestReleaseDate, path: 'api/lib/config.js' })
.query({ since: secondToLastReleaseDate, until: latestReleaseDate, path: 'api/src/shared/config.js' })
.reply(200, []);

nock('https://api.github.com')
Expand Down