[TECH] Mettre à jour cron de 1.8 à 2.1 #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentHardouin
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
Leurs versions sont quand même foireuses. Ils prétendent avoir un breaking-change en version 2. Seulement celui-ci est fait en 1.8.3 .
Sinon la PR reste good merci 🙏
francois2metz
approved these changes
Sep 6, 2022
De ce que je comprends, le breaking change est le remplacement de moment par luxon, qui n'a pas le même support (prise en charge des versions anciennes de Node / navigateur. Ce n'a pas d'impact pour nous qui utilisons une version de Node récente. |
octo-topi
added
Tech Review OK
🚀 Ready to Merge
and removed
Development in progress
labels
github-actions
bot
force-pushed
the
tech-bump-cron-1.8-to-2.1.0
branch
from
8ec53c8
to
a1e4fde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
La dépendance cron a une nouvelle version majeure.
🤖 Solution
Utiliser cette version.
🌈 Remarques
Changelog des breaking changes https://github.com/kelektiv/node-cron/blob/master/CHANGELOG.md
💯 Pour tester
Vérifier que la CI passe ?