Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TECH] Créer une application Scalingo depuis Slack #144

Merged
merged 1 commit into from
Sep 6, 2022
Merged

[TECH] Créer une application Scalingo depuis Slack #144

merged 1 commit into from
Sep 6, 2022

Conversation

yoandl
Copy link
Contributor

@yoandl yoandl commented Aug 25, 2022 •
edited by octo-topi
Loading

🦄 Problème

L'ajout d'une app sur Scalingo demande de se connecter 2 fois pour la créer et l'assigner sur son compte perso.

🤖 Solution

Ajouter un raccourcis slack pour créer l'app et ajouter automatiquement l'utilisateur dans les collaborateurs.

🌈 Remarques

Des infos supplémentaires, trucs et astuces ?

💯 Pour tester

Indiquer comment tester depuis le slack de test

@yoandl yoandl added team-captains This is your captain speaking Development in progress labels Aug 25, 2022
@yoandl yoandl force-pushed the add-slack-scalingo-shortcut branch 2 times, most recently from 3c1db31 to 4702e5b Compare August 30, 2022 12:37
@yoandl yoandl force-pushed the add-slack-scalingo-shortcut branch from 2b80fa9 to 746a2a6 Compare August 30, 2022 15:01
@octo-topi octo-topi changed the title [TECH] Ajout de raccourcis sur Slack pour la création d'app sur Scalingo [TECH] Créer une application Scalingo depuis Slack Sep 2, 2022
octo-topi
octo-topi suggested changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@octo-topi octo-topi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tous les commits ne passent pas les tests, et les fonctionnalités ne sont pas ajoutées de manière incrémentale, je vois deux solutions:

  • brutale: squasher tous les commits en un seul
  • mieux (si pas nécessaire de tout réécrire): faire des fixup de commit pour regrouper test et implémentation.

NB: pour éviter au moins les erreurs de lint, installer le hook de pre-commit dans une autre PR

octo-topi
octo-topi reviewed Sep 2, 2022
View reviewed changes
config.js Show resolved Hide resolved
@yoandl yoandl force-pushed the add-slack-scalingo-shortcut branch 2 times, most recently from e7351d3 to 38077e8 Compare September 2, 2022 11:11
@yoandl yoandl force-pushed the add-slack-scalingo-shortcut branch 2 times, most recently from 624703d to 37e2070 Compare September 5, 2022 09:46
@yoandl @mickaelalibert
@francois2metz @octo-topi
✨ creation scalingo application from slack
afde7a4 
Co-authored-by: Mickael Alibert <mickael.alibert@pix.fr>
Co-authored-by: Yoan De Luca <yoan.de-luca@pix.fr>
Co-authored-by: François De Metz <francois.de-metz@pix.fr>
Co-authored-by: Pierre Top <pierre.top@pix.fr>
@github-actions github-actions bot merged commit 1e6d6ca into main Sep 6, 2022
@github-actions github-actions bot deleted the add-slack-scalingo-shortcut branch September 6, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octo-topi octo-topi octo-topi approved these changes

Assignees
No one assigned
Labels
🚀 Ready to Merge team-captains This is your captain speaking Tech Review OK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoandl @octo-topi