[BUGFIX] Utiliser les commits entre les 2 releases pour afficher une notification de changement de config lors du déploiement #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentHardouin
force-pushed
the
fix-config-change-notification
branch
from
607dff5
to
08ef012
Compare
MathieuGilet
approved these changes
Aug 5, 2022
yannbertrand
reviewed
Aug 8, 2022
yannbertrand
reviewed
Aug 8, 2022
| }, | ||
| } | ||
| }); | ||
|
|
||
| nock('https://api.github.com') | ||
| .get('/repos/github-owner/github-repository/commits?since=2011-04-14&path=api%2Flib%2Fconfig.js') | ||
| .filteringPath(/since=\d{4}-\d{2}-\d{2}T\d{2}%3A\d{2}%3A\d{2}.\d{3}Z&until=\d{4}-\d{2}-\d{2}T\d{2}%3A\d{2}%3A\d{2}.\d{3}Z/g, 'since=XXXX&until=XXXX') |
VincentHardouin
force-pushed
the
fix-config-change-notification
branch
from
7e931c9
to
0fade39
Compare
VincentHardouin
added
🚀 Ready to Merge
Tech Review OK
and removed
Tech Review Needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Actuellement, lors de la MEP d'une release un message de modification du fichier de config peut-être affichée si un commit a modifié le fichier entre la release et le dernier commit sur dev.
Cependant, une MEP correspond à la mise en production d'une release créé pendant la MER.
🤖 Solution
🌈 Remarques
💯 Pour tester