Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Générer le manifest pour configurer les applications slack #114

Merged
merged 3 commits into from
Apr 27, 2022

Conversation

francois2metz
Copy link
Contributor

@francois2metz francois2metz commented Apr 25, 2022

🦄 Problème

La configuration des applications slack Pix est manuelle. Il faut se baser sur ce qui se passe sur la production, mais nous n'avons pas de documentation de ce qui est fait.

🤖 Solution

Slack a rajouté le support des app manifest qui permettent de configurer une application slack d'un coup: https://api.slack.com/reference/manifests. 2 routes ont été rajouté pour retourner les manifest de build et de run.

🌈 Remarques

Les manifest sont généré et mis à jour manuellement. Ca va bientôt changer.

💯 Pour tester

  1. Lancer pix-bot
  2. Aller sur http://localhost:3000/run/manifest et regarder la config
  3. Aller sur http://localhost:3000/build/manifest et regarder la config

Copy link
Contributor

@mickaelalibert mickaelalibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐽

run/controllers/manifest.js Outdated Show resolved Hide resolved
test/acceptance/run/manifest_test.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Ready to Merge team-captains This is your captain speaking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants