Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decentralised governance of 0x protocol and treasury #641

Merged
merged 106 commits into from
Mar 22, 2023
Merged

Decentralised governance of 0x protocol and treasury #641

merged 106 commits into from
Mar 22, 2023

Commits on Mar 10, 2023

  1. Install open zeppelin contracts

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    7f26c5d View commit details
    Browse the repository at this point in the history

  2. Init foundry in governance

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    4f39ff1 View commit details
    Browse the repository at this point in the history

  3. Add wrapped ZRX token

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    2b42a6e View commit details
    Browse the repository at this point in the history

  4. Add governance contracts testing to CI

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    1b9f4fe View commit details
    Browse the repository at this point in the history

  5. Set optimizer runs to default

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    3f18f9d View commit details
    Browse the repository at this point in the history

  6. Upgrade to patched version of openzeppelin/contracts

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    71cfb20 View commit details
    Browse the repository at this point in the history

  7. Test stakingakng / unwrapping ZRX

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    8ab6af4 View commit details
    Browse the repository at this point in the history

  8. Init npm package

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    c07065f View commit details
    Browse the repository at this point in the history

  9. Lint fix, removing lib from gitignore

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    5ce63d4 View commit details
    Browse the repository at this point in the history

  10. Add openzeppelin contracts git submodule for foundry

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    f222bda View commit details
    Browse the repository at this point in the history

  11. Add vanilla governor contract

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    ca30706 View commit details
    Browse the repository at this point in the history

  12. Fix reference paths to imported packages

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    265a50c View commit details
    Browse the repository at this point in the history

  13. Temporarily switch to using a mocked version of ZRX

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    7546b9c View commit details
    Browse the repository at this point in the history

  14. Ignore foundry's lib in link checker

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    07610c8 View commit details
    Browse the repository at this point in the history

  15. Fix a conflict in gitignore between forge lib adn built lib

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    de21d3d View commit details
    Browse the repository at this point in the history

  16. Upload governance code coverage report to coveralls

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    7bf9dce View commit details
    Browse the repository at this point in the history

  17. Flesh out test scenarios for wrapping/unwrapping

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    d80789c View commit details
    Browse the repository at this point in the history

  18. Add basic ERC20 name and symbol tests

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    a36277f View commit details
    Browse the repository at this point in the history

  19. Wire in basic timelock controller and governor test setup

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    5433b8a View commit details
    Browse the repository at this point in the history

  20. Test basic governor properties

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    4e41229 View commit details
    Browse the repository at this point in the history

  21. Add basic voting power delegation tests

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    f4db939 View commit details
    Browse the repository at this point in the history

  22. Add proposal execution happy path test

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    cccaf31 View commit details
    Browse the repository at this point in the history

  23. Split ERC20Votes logic between wrapped token 

    and ZeroExVotes contracts
    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    e07260f View commit details
    Browse the repository at this point in the history

  24. Exclude BaseTest from coverage in coveralls

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    0685866 View commit details
    Browse the repository at this point in the history

  25. Add protocol specific governor with produciton governance settings

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    adf73a7 View commit details
    Browse the repository at this point in the history

  26. Add a dedicated instance for the treasury governor 

    This is currently using the default 1 token 1 vote mechanism but will be migrated
    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    7e1b858 View commit details
    Browse the repository at this point in the history

  27. Add test for updating governance settings 

    for voting delay, voting period and proposal threshold
    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    a656365 View commit details
    Browse the repository at this point in the history

  28. Create seperate timelock contract instance for treasury and protocol

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    73bb6a4 View commit details
    Browse the repository at this point in the history

  29. Test updating the timlock min delay

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    6cff23d View commit details
    Browse the repository at this point in the history

  30. Set timelock delay to 2 days for protocol and 1 sec for treasury

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    7691aef View commit details
    Browse the repository at this point in the history

  31. Remove timelock from treasury governor

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    0223e16 View commit details
    Browse the repository at this point in the history

  32. Refactor _checkpointsLookup to return entire Checkpoint 

    instad of just number of votes
    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    5fbfcb7 View commit details
    Browse the repository at this point in the history

  33. Update the totalSupply checkpoints updating logic

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    1522fff View commit details
    Browse the repository at this point in the history

  34. Quadratic voting power transfers and delegations

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    204b2ee View commit details
    Browse the repository at this point in the history

  35. Fix workflow yaml

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    c704869 View commit details
    Browse the repository at this point in the history

  36. Initialise ZeroExVotes behind a ERC1967Proxy 

    Test it cannot be reinitialised
    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    3ae3b0d View commit details
    Browse the repository at this point in the history

  37. Remove obsoleted console.logs from test

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    e128c5b View commit details
    Browse the repository at this point in the history

  38. Storage pack Checkpoint enum

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    7359a64 View commit details
    Browse the repository at this point in the history

  39. Remove keeping track of total balances for voting

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    a381b82 View commit details
    Browse the repository at this point in the history

  40. Switch to using the foundry artifact in test

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    9fd66a1 View commit details
    Browse the repository at this point in the history

  41. Fix rebase issue

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    c1966e0 View commit details
    Browse the repository at this point in the history

  42. Add timelock control over the treasury governor

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    f258bb4 View commit details
    Browse the repository at this point in the history

  43. Add test for wrapped token transfer

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    091e0a5 View commit details
    Browse the repository at this point in the history

  44. Emit separate events for changing linear and quadratic voting power

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    e223ba0 View commit details
    Browse the repository at this point in the history

  45. Add the ability to cancel a proposal

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    d18c3ca View commit details
    Browse the repository at this point in the history

  46. Limit the governors' cancel function to security council only

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    94adc8f View commit details
    Browse the repository at this point in the history

  47. Eject security council after a proposal is cancelled

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    9f96dcb View commit details
    Browse the repository at this point in the history

  48. Add ability for governance to set the security council

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    5afedda View commit details
    Browse the repository at this point in the history

  49. Merge the governors test suites into one reusable set of tests

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    b430183 View commit details
    Browse the repository at this point in the history

  50. Add an empty test function to base test contract 

    to remove it from coverage reports. Fudge but no other way to ignore it in report
    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    e1c1416 View commit details
    Browse the repository at this point in the history

  51. Security council can rollback protocol upgrades

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    905c993 View commit details
    Browse the repository at this point in the history

  52. Upgrade to solidity 0.8.19

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    1d9d324 View commit details
    Browse the repository at this point in the history

  53. Move IZeroExGovernor to src

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    1484222 View commit details
    Browse the repository at this point in the history

  54. Abstract Security council interface into its own

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    14776b5 View commit details
    Browse the repository at this point in the history

  55. Emit events when assigning and ejecting the security council

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    58f8dd1 View commit details
    Browse the repository at this point in the history

  56. Use a cast to bytes4 instead of LibBytes 

    Co-authored-by: duncancmt <1207590+duncancmt@users.noreply.github.com>
    @elenadimitrova @duncancmt
    elenadimitrova and duncancmt committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    9bca5b9 View commit details
    Browse the repository at this point in the history

  57. Writing total supply checkpoints and setup of 

    quorum percentage of quadratic total supply for treasure governor
    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    5630eec View commit details
    Browse the repository at this point in the history

  58. Add test for transferring tokens when delegating

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    2867181 View commit details
    Browse the repository at this point in the history

  59. Rename IZeroExSecurityCouncil to ISecurityCouncil

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    43bc935 View commit details
    Browse the repository at this point in the history

  60. Add security council restrictions to governors

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    42e1b13 View commit details
    Browse the repository at this point in the history

  61. Remove obsolete overflow check

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    bcbf039 View commit details
    Browse the repository at this point in the history

  62. Improve test coverage

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    986ebf3 View commit details
    Browse the repository at this point in the history

  63. Upgrade open-zeppelin contracts to 4.8.2

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    094de01 View commit details
    Browse the repository at this point in the history

  64. Test delegation by signature

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    9e873e1 View commit details
    Browse the repository at this point in the history

  65. Test non security council requests 

    to rollback protocol changes cannot be executed
    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    6a86ba1 View commit details
    Browse the repository at this point in the history

  66. Better revert messages

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    4dbbc05 View commit details
    Browse the repository at this point in the history

  67. Test correct interfaces are supported

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    d361ba7 View commit details
    Browse the repository at this point in the history

  68. Remove obsoleted funciton

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    73070bd View commit details
    Browse the repository at this point in the history

  69. Further test delegation by signature scenario

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    99a7b73 View commit details
    Browse the repository at this point in the history

  70. Split the delegation functionality tests

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    76e12ab View commit details
    Browse the repository at this point in the history

  71. Add test for initialisation of voting contract

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    1d8e3ca View commit details
    Browse the repository at this point in the history

  72. Add test for reading checkpoints

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    d8a867f View commit details
    Browse the repository at this point in the history

  73. Update code comments

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    da8537c View commit details
    Browse the repository at this point in the history

  74. Fix compilation warnings

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    4283fbd View commit details
    Browse the repository at this point in the history

  75. Run smt checker

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    2132b9a View commit details
    Browse the repository at this point in the history

  76. Add checkpoint tests

    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    0e84a1d View commit details
    Browse the repository at this point in the history

  77. Rename parameter in moveEntireVotingPower to match the one in movePar… 

    …tialVotingPower
    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    7024a11 View commit details
    Browse the repository at this point in the history

  78. Switch moveEntireVotingPower to a more generic moveVotingPower implem… 

    …entation

as in the open-zeppelin contracts
    @elenadimitrova
    elenadimitrova committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    4132cfb View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2023

  1. Install foundry earlier in CI

    @elenadimitrova
    elenadimitrova committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    6c8ac9a View commit details
    Browse the repository at this point in the history

  2. Switch movePartialVotingPower to the generic moveVotingPower implemen… 

    …tation
    @elenadimitrova
    elenadimitrova committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    a650418 View commit details
    Browse the repository at this point in the history

  3. Write totalSupplyCheckpoints via the generic _writeCheckpoint

    @elenadimitrova
    elenadimitrova committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    a54a94e View commit details
    Browse the repository at this point in the history

  4. Add threshold for quadratic voting power

    @elenadimitrova
    elenadimitrova committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    46632d5 View commit details
    Browse the repository at this point in the history

  5. Remove autoinserted code by OZ

    @elenadimitrova
    elenadimitrova committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    8006646 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. Add openzeppelin/contracts-upgradable

    @elenadimitrova
    elenadimitrova committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    55806c6 View commit details
    Browse the repository at this point in the history

  2. Add initializable base to Voting contract

    @elenadimitrova
    elenadimitrova committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    ce87bad View commit details
    Browse the repository at this point in the history

  3. Fix terminogy error in natspec

    @elenadimitrova
    elenadimitrova committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    5773efd View commit details
    Browse the repository at this point in the history

  4. Fix code comment

    @elenadimitrova
    elenadimitrova committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    403455b View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. Remove obsoleted overrides and add a missing modifier to moveVotingPower

    @elenadimitrova
    elenadimitrova committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    545cf87 View commit details
    Browse the repository at this point in the history

  2. Remove amount check 

    Co-authored-by: duncancmt <1207590+duncancmt@users.noreply.github.com>
    @elenadimitrova @duncancmt
    elenadimitrova and duncancmt committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    b55baab View commit details
    Browse the repository at this point in the history

  3. Fix a calculation error and clean tests

    @elenadimitrova
    elenadimitrova committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    b8d67f0 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. Update thresholds for treasury governor

    @elenadimitrova
    elenadimitrova committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    8961e1d View commit details
    Browse the repository at this point in the history

  2. Fix testShouldNotBeAbleToDelegateWithSignatureAfterExpiry

    @duncancmt @elenadimitrova
    duncancmt authored and elenadimitrova committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    7be528e View commit details
    Browse the repository at this point in the history

  3. Update from @duncancmt 

    without "memory-safe" the IR optimizer produces significantly worse code and it disables the stack limit evader

Co-authored-by: duncancmt <1207590+duncancmt@users.noreply.github.com>
    @elenadimitrova @duncancmt
    elenadimitrova and duncancmt committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    89c77a7 View commit details
    Browse the repository at this point in the history

  4. Add onlyProxy to initializer

    @duncancmt @elenadimitrova
    duncancmt authored and elenadimitrova committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    15210fa View commit details
    Browse the repository at this point in the history

  5. Fix quadratic voting weight base

    @elenadimitrova
    elenadimitrova committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    0c1a7bc View commit details
    Browse the repository at this point in the history

  6. Rename voting parameter for clarity

    @elenadimitrova
    elenadimitrova committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    9c47969 View commit details
    Browse the repository at this point in the history

  7. Make addresses immutable (#680) 

    * Make addresses immutable

* Fix linting issues

---------

Co-authored-by: elenadimitrova <elena@arenabg.com>
    @duncancmt @elenadimitrova
    duncancmt and elenadimitrova committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    92efa2e View commit details
    Browse the repository at this point in the history

  8. Prevent griefing by a malicious ZeroExVotes upgrade (#681) 

    * Gas optimization

* Minimal change to prevent malicious ZeroExVotes from griefing

* Add demonstration of griefing upgrade

* Fix rebase issues with tests

* Fix prettier issues

* Add checks to test

---------

Co-authored-by: elenadimitrova <elena@arenabg.com>
    @duncancmt @elenadimitrova
    duncancmt and elenadimitrova committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    b1c83eb View commit details
    Browse the repository at this point in the history

  9. Rename SecurityCouncil contract

    @elenadimitrova
    elenadimitrova committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    fb6e1f0 View commit details
    Browse the repository at this point in the history

  10. Add timestamp to delegator balance updates

    @elenadimitrova
    elenadimitrova committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    4f799ca View commit details
    Browse the repository at this point in the history

  11. Make quadraticThreshold immutable for gas efficiency

    @duncancmt @elenadimitrova
    duncancmt authored and elenadimitrova committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    3070276 View commit details
    Browse the repository at this point in the history

  12. Remove the logic for ejecting security council

    @elenadimitrova
    elenadimitrova committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    538c61f View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Switch balance timestamp to be a block number

    @elenadimitrova
    elenadimitrova committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    6410ffc View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. Test votes migration for adding a new vote weight mechanism (#674) 

    * Add Emacs files to .gitignore

* Make some functions unproected to demonstrate a migration

* Add example (broken) migration

* Add migration test for voting logic

* Try to simplify tests

* Fix compilation errors

* Fix underflow test with new logic

* Flesh out migration test for voting

* Replace cube root library

* Fix stack too deep in coverage

---------

Co-authored-by: elenadimitrova <elena@arenabg.com>
    @duncancmt @elenadimitrova
    duncancmt and elenadimitrova committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    62fe71b View commit details
    Browse the repository at this point in the history

  2. Change test case to testFail

    @elenadimitrova
    elenadimitrova committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    d6c0c02 View commit details
    Browse the repository at this point in the history

  3. Update contracts/governance/test/ZeroExVotesMigration.sol 

    Co-authored-by: duncancmt <1207590+duncancmt@users.noreply.github.com>
    @elenadimitrova @duncancmt
    elenadimitrova and duncancmt committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    8d83419 View commit details
    Browse the repository at this point in the history