Fix tx OOC (node level) when first empty L2 block in batch #3744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnusmor
added
cherry-picked
tclemos
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
The solution to the problem seems ok, but the PR is lacking tests.
It would be good to have these scenarios:
- OOC for the first empty block
- OOC for any other block than the first
both checking the TX was invalidated and removed from the worker
I'll keep it approved in case we need this, but if the fix is not urgent, I recommend adding those tests.
giskook
pushed a commit
to okx/xlayer-node
that referenced
this pull request
Aug 7, 2024
…Hermez#3744) * Fix tx OOC (node level) for first empty L2 block in batch * change log level for ooc (node level) when adding tx to the worker * fix check OOC (node level) when preexecuting the tx in RPC * Fix linter and test
agnusmor
added a commit
that referenced
this pull request
Aug 12, 2024
* Fix tx OOC (node level) for first empty L2 block in batch * change log level for ooc (node level) when adding tx to the worker * fix check OOC (node level) when preexecuting the tx in RPC * Fix linter and test
agnusmor
added a commit
that referenced
this pull request
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix tx OOC (node level) when first empty L2 block in batch
Reviewers
Main reviewers:
@tclemos
@joanestebanr