Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update datastream file #3741

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Fix update datastream file #3741

merged 2 commits into from
Jul 24, 2024

Conversation

agnusmor
Copy link
Contributor

What does this PR do?

Several fixes in GenerateDataStreamFile function:

  • Fixes "Batch end" entry when batch is WIP
  • Fixes getting timestamp of previous L2 block when last entry is a transaction
  • Fixes getting current batch number when last entry is a transaction

Reviewers

Main reviewers:

@ToniRamirezM

@agnusmor agnusmor added cherry-picked Content has been cherry-picked into a higher version branch zkevm-seq-agg labels Jul 24, 2024
@agnusmor agnusmor added this to the v0.7.1 milestone Jul 24, 2024
@agnusmor agnusmor self-assigned this Jul 24, 2024
@cla-bot cla-bot bot added the cla-signed label Jul 24, 2024
@agnusmor agnusmor merged commit 1adc67d into release/v0.7.1 Jul 24, 2024
16 checks passed
@agnusmor agnusmor deleted the fix/update-ds branch July 24, 2024 09:47
agnusmor added a commit that referenced this pull request Aug 9, 2024
* Update datastream file fixes: end batch entry, previous L2 block timestamp, current batch number

* Use GetFirstEventAfterBookmark
agnusmor added a commit that referenced this pull request Aug 9, 2024
* Update datastream file fixes: end batch entry, previous L2 block timestamp, current batch number

* Use GetFirstEventAfterBookmark
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked Content has been cherry-picked into a higher version branch cla-signed zkevm-seq-agg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants