Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ renamed config vars for L1 parallel sync #2768

Conversation

joanestebanr
Copy link
Contributor

@joanestebanr joanestebanr commented Nov 8, 2023

Closes #2767

What does this PR do?

Next parameters have been changed:

L1SynchronizationMode = parallel
	[Synchronizer.L1ParallelSynchronization]
		MaxClients = 10
		MaxPendingNoProcessedBlocks = 25
		RequestLastBlockPeriod = "5s"
		RequestLastBlockTimeout = "5s"
		RequestLastBlockMaxRetries = 3
		StatisticsPeriod = "5m"
		TimeoutMainLoop = "5m"
		RollupInfoRetriesSpacing= "5s"
		FallbackToSequentialModeOnSynchronized = false
		[Synchronizer.L1ParallelSynchronization.PerformanceWarning]
			AceptableInacctivityTime = "5s"
			ApplyAfterNumRollupReceived = 10

this are the old ones:

UseParallelModeForL1Synchronization = true
	[Synchronizer.L1ParallelSynchronization]
		NumberOfParallelOfEthereumClients = 10
		CapacityOfBufferingRollupInfoFromL1 = 25
		TimeForCheckLastBlockOnL1Time = "5s"
		TimeoutForRequestLastBlockOnL1 = "5s"
		MaxNumberOfRetriesForRequestLastBlockOnL1 = 3
		TimeForShowUpStatisticsLog = "5m"
		TimeOutMainLoop = "5m"
		MinTimeBetweenRetriesForRollupInfo = "5s"
                SwitchToSequentialModeIfIsSynchronized = false
		[Synchronizer.L1ParallelSynchronization.PerformanceCheck]
			AcceptableTimeWaitingForNewRollupInfo = "5s"
			NumIterationsBeforeStartCheckingTimeWaitinfForNewRollupInfo = 10	

Reviewers

@ARR552
@agnusmor

@joanestebanr joanestebanr merged commit a4770f3 into release/v0.4.0 Nov 8, 2023
16 checks passed
@joanestebanr joanestebanr deleted the feature/2767-renaming_config_vars_for_parallel_sync branch November 8, 2023 17:02
joanestebanr added a commit that referenced this pull request Nov 9, 2023
* + renamed config vars for L1 parallel sync
joanestebanr added a commit that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants