fix new error handling #2737
Merged
fix new error handling #2737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnusmor
approved these changes
Oct 31, 2023
agnusmor
added a commit
that referenced
this pull request
Oct 31, 2023
…nce opcodes flags, new formula) (#2690) * initial changes related to revision of effective gas price implementation * Use EffectiveGasPriceLog struct to log/store EGP calculation details * added egp tests and logs. Update executor proto * implementation EGP for RPC (#2652) * implementation EGP for RPC * added additional fields to EGPLog. Several fixes * use BreakEvenFactor instead or pct margin. RPC egp-log changed * fix white spaces * fix lint and doc * change pool egp logs * fix nil evaluation on pool.StoreTx * Revert "fix nil evaluation on pool.StoreTx" This reverts commit 958a41f. * fix pgstatestorage tests * fix config doc * added HasOpCode e2e test * Added HasOpCode e2e test. Improve logs. Fixes * Fix finalizer tests * change egp checks * fix PR review comments * fix new error handling (#2737) --------- Co-authored-by: Joan Esteban <129153821+joanestebanr@users.noreply.github.com> Co-authored-by: Toni Ramírez <58293609+ToniRamirezM@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes new executor error handling