bugfix: adding deletion of invalid txs from pool db in the finalizer. #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Psykepro
force-pushed
the
bugfix/delete-invalid-txs-from-pool
branch
2 times, most recently
from
61fe998
to
6a47c1e
Compare
agnusmor
reviewed
Feb 24, 2023
sequencer/finalizer.go
Outdated
| @@ -421,6 +421,10 @@ func (f *finalizer) handleTransactionError(ctx context.Context, result *state.Pr | |||
| log.Errorf("ROM out of counters error, marking tx with Hash: %s as INVALID, errorCode: %s", tx.Hash.String(), errorCode.String()) | |||
| start := time.Now() | |||
| f.worker.DeleteTx(tx.Hash, tx.From) | |||
| err := f.dbManager.UpdateTxStatus(ctx, tx.Hash, pool.TxStatusFailed) | |||
| if err != nil { | |||
| log.Errorf("failed to delete tx from pool, err: %s", err) | |||
There was a problem hiding this comment.
the log message must be "failed to update tx from pool, err:" (not "delete")
There was a problem hiding this comment.
ops yep forgot to update the log
There was a problem hiding this comment.
will make it more explicit like that:
log.Errorf("failed to update status to failed in the pool for tx: %s, err: %s", tx.Hash.String(), err)
Psykepro
force-pushed
the
bugfix/delete-invalid-txs-from-pool
branch
from
6a47c1e
to
30410af
Compare
Signed-off-by: Nikolay Nedkov <nikolai_nedkov@yahoo.com>
Psykepro
force-pushed
the
bugfix/delete-invalid-txs-from-pool
branch
from
30410af
to
32571ad
Compare
ToniRamirezM
approved these changes
Feb 27, 2023
tclemos
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1695
What does this PR do?
Adding missing deletion of invalid to process txs in finalizer from pool db.
Reviewers
Main reviewers:
Codeowner reviewers: