Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the e2e table test as it wasn't being used #408

Merged
merged 2 commits into from
May 8, 2023

Conversation

acroca
Copy link
Contributor

@acroca acroca commented May 5, 2023

The table test data wasn't used at all, it contained a happy path test bridging eth.

@acroca acroca requested review from ARR552 and jrs-engineer May 5, 2023 05:37
@acroca acroca self-assigned this May 5, 2023
@cla-bot
Copy link

cla-bot bot commented May 5, 2023

We require contributors/corporates @acroca to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document

@jrs-engineer
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label May 5, 2023
@cla-bot
Copy link

cla-bot bot commented May 5, 2023

The cla-bot has been summoned, and re-checked this pull request!

Copy link
Contributor

@jrs-engineer jrs-engineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@ARR552 please check this removing, I am not sure about the original use-case of e2e-test.json file

Copy link
Contributor

@ARR552 ARR552 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We supposed to have some test vectors to test the e2e but they never reached. Thats why we had to create these tests

@acroca acroca merged commit f59eab0 into develop May 8, 2023
@acroca acroca deleted the remove-e2e-table-test branch May 8, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants