Skip to content

Commit

Permalink
mm-prepare-page_referenced-and-page_idle-to-new-thp-refcounting-check…
Browse files Browse the repository at this point in the history
…patch-fixes

ERROR: code indent should use tabs where possible
torvalds#171: FILE: mm/page_idle.c:75:
+                if (!pmd_present(*pmd))$

WARNING: please, no spaces at the start of a line
torvalds#171: FILE: mm/page_idle.c:75:
+                if (!pmd_present(*pmd))$

WARNING: Missing a blank line after declarations
torvalds#194: FILE: mm/page_idle.c:93:
+		pmd_t pmde = *pmd;
+		barrier();

WARNING: Missing a blank line after declarations
torvalds#304: FILE: mm/rmap.c:867:
+		pmd_t pmde = *pmd;
+		barrier();

total: 1 errors, 3 warnings, 327 lines checked

NOTE: Whitespace errors detected.
      You may wish to use scripts/cleanpatch or scripts/cleanfile

./patches/mm-prepare-page_referenced-and-page_idle-to-new-thp-refcounting.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
  • Loading branch information
akpm00 authored and sfrothwell committed Dec 9, 2015
1 parent 880a731 commit 36603c4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
3 changes: 2 additions & 1 deletion mm/page_idle.c
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ static int page_idle_clear_pte_refs_one(struct page *page,

if (pmd_trans_huge(*pmd)) {
ptl = pmd_lock(mm, pmd);
if (!pmd_present(*pmd))
if (!pmd_present(*pmd))
goto unlock_pmd;
if (unlikely(!pmd_trans_huge(*pmd))) {
spin_unlock(ptl);
Expand All @@ -90,6 +90,7 @@ static int page_idle_clear_pte_refs_one(struct page *page,
return SWAP_AGAIN;
} else {
pmd_t pmde = *pmd;

barrier();
if (!pmd_present(pmde) || pmd_trans_huge(pmde))
return SWAP_AGAIN;
Expand Down
1 change: 1 addition & 0 deletions mm/rmap.c
Original file line number Diff line number Diff line change
Expand Up @@ -866,6 +866,7 @@ static int page_referenced_one(struct page *page, struct vm_area_struct *vma,
return ret;
} else {
pmd_t pmde = *pmd;

barrier();
if (!pmd_present(pmde) || pmd_trans_huge(pmde))
return SWAP_AGAIN;
Expand Down

0 comments on commit 36603c4

Please sign in to comment.