feat: Modernize DokuWiki Discord Notifier Plugin #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces several modernizations to the DokuWiki Discord Notifier plugin:
Removed obsolete DOKU_INC definition check in helper.php to align with modern DokuWiki loading mechanisms.
Replaced $_SERVER['REMOTE_USER'] with $INPUT->server->str('REMOTE_USER') in helper.php for safer and type-aware access to server variables, adhering to DokuWiki's $INPUT global object best practices.
These changes ensure better compatibility with DokuWiki 2025-05-14a "Librarian" and improve adherence to modern PHP development standards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces several modernizations to the DokuWiki Discord Notifier plugin:
Removed obsolete DOKU_INC definition check in helper.php to align with modern DokuWiki loading mechanisms. Replaced $_SERVER['REMOTE_USER'] with $INPUT->server->str('REMOTE_USER') in helper.php for safer and type-aware access to server variables, adhering to DokuWiki's $INPUT global object best practices. These changes ensure better compatibility with DokuWiki 2025-05-14a "Librarian" and improve adherence to modern PHP development standards.