nrf70: Fix ret code for xmit #93060
Open
nrf70: Fix ret code for xmit #93060
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return proper error codes for xmit instead of generic -1. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
None of the drivers seem to return the number of bytes, they all return 0 for success, so, fix the docs. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
github-actions
bot
requested review from
jukkar,
Kludentwo,
MaochenWang1,
pdgendt,
rlubos,
sachinthegreen and
ssharks
|
jukkar
reviewed
Jul 13, 2025
There was a problem hiding this comment.
Indeed, this seems to be the case. From the callers https://github.com/search?q=repo%3Azephyrproject-rtos%2Fzephyr%20net_l2_send&type=code it seems that at least ppp is using the ret value to update the statistics. Could you check the callers of l2 send that they work ok after this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix return codes for xmit and also fix ret code docs.