Skip to content

Fixes to PAJ7620 driver and code sample #93044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixes to PAJ7620 driver and code sample #93044

wants to merge 2 commits into from
+58 −40

Conversation

kartben
Copy link
Collaborator

@kartben kartben commented Jul 11, 2025 •
edited
Loading

  • Fix compilation issue when enabling sensors logs, due to log module using duplicate name
  • Clean up sample to actually allow polling mode to be used when trigger mode is not even configured in DT (previously the sample would unconditionally enable CONFIG_PAJ7620_TRIGGER_OWN_THREAD and just assume that the user had configured int-gpios in DT which might not always be the case...).

@kartben
drivers: sensor: paj7620: fix duplicate log module
0592388 
paj7620 log module was being registered twice
use `paj7620_trigger` as the name for logging in paj7620_trigger.c

Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
@kartben kartben marked this pull request as ready for review July 11, 2025 22:05
@kartben
Copy link
Collaborator Author

kartben commented Jul 11, 2025

cc @paultimke

@kartben kartben changed the title Fixes to PAJ7620 driver and code samples Fixes to PAJ7620 driver and code sample Jul 11, 2025
@kartben
samples: sensor: paj7620: refactor handling of trigger mode
c4e5c95 
The current sample was always trying to enable trigger mode in the
driver no matter what, causing issues for instances where the sensor
simply has no interrupt pin configured in Devicetree.

Cleaned things up so that enabling trigger mode is done via the
driver's Kconfig option, and cleaned up the Twister testcases
accordingly (plus, made sure they are actually built by setting
min_ram to a value compatibel with the nucleo_f334r8).

README has also been updated to clearly document how to enable
either mode.

Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faxe1008 faxe1008 faxe1008 approved these changes

@asemjonovs asemjonovs Awaiting requested review from asemjonovs

@avisconti avisconti Awaiting requested review from avisconti

@jeppenodgaard jeppenodgaard Awaiting requested review from jeppenodgaard

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@nashif nashif Awaiting requested review from nashif

@teburd teburd Awaiting requested review from teburd

@tristan-google tristan-google Awaiting requested review from tristan-google

@ubieda ubieda Awaiting requested review from ubieda

@yperess yperess Awaiting requested review from yperess

At least 2 approving reviews are required to merge this pull request.

Assignees

@MaureenHelm MaureenHelm

Labels
area: Samples Samples area: Sensors Sensors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kartben @faxe1008 @MaureenHelm