XWIKI-23354: The #documentTree($option) is broken when using the showTerminalPages=false

[Farcasut]

Jira URL

https://jira.xwiki.org/browse/XWIKI-23354

Changes

Description

Updated the alias of the XWikiSpace table to spaces instead of page, to match the alias used in the filters.

Clarifications

When we do not want to show terminal documents, we reach this else branch. The query created is:

select reference, 0 as terminal from XWikiSpace page order by lower(name), name

where the alias of XWikiSpace is page. Below, we add some filters and the ChildPageFilter uses space as the alias for the table:

xwiki-platform/xwiki-platform-core/xwiki-platform-index/xwiki-platform-index-tree/xwiki-platform-index-tree-api/src/main/java/org/xwiki/index/tree/internal/nestedpages/query/ChildPageFilter.java

Line 45 in 28991f7

statement.indexOf("XWS_REFERENCE") < 0 ? "space.parent = :parent " : "XWS_PARENT = :parent ";

and because of this the query fails.

Screenshots & Video

Executed Tests

Expected Merging Strategy

• Prefers squash: Yes
• Backport on branches: 16.10.x