Skip to content

XWIKI-22999: Activity stream should use list semantics #4357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented Jul 2, 2025

Jira URL

https://jira.xwiki.org/browse/XWIKI-22999

Changes

Description

  • Added list semantics to the notification macro.

Clarifications

  • The notification macro is used among other things in the activity stream. It's also used notably in the notification dropdown.
  • In order to minimize the DOM changes (and also not have to change much the blocks in the HTMLRenderer), I used the aria role="listitem" instead of <li> in the notifier script service.

Screenshots & Video

Executed Tests

Successfully built wqith the changes:

  • mvn clean install -f xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api -Pquality
  • mvn clean install -f xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-macro/xwiki-platform-notifications-macro-ui

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • None, this is a DOM change that could break extensions and customizations

* Added list semantics to the notification macro, which is used among other things in the activity stream. It's also used notably in the notification dropdown.
@Sereza7 Sereza7 requested a review from surli July 15, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants