Fix sorting in Domain Selection screen #24631
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kean
commented
Jun 26, 2025
| } else { | ||
| // If neither rhs nor lhs ara a match then sort alphabetically | ||
| return lhs.domainName.caseInsensitiveCompare(rhs.domainName) == .orderedAscending | ||
| completion(Result.failure(error)) |
There was a problem hiding this comment.
RCA:
- Server returns results already sorted by relevance. If the query is specific enough, it might start returning low-relevance domains with dashes at the bottom of the response:
{
"domain_name": "buy-a-simple-domain.casa",
"relevance": 0.32,
- The spring incorrectly sorts the domains with dashes earlier than the same domains without them.
The app doesn't need the extra sorting as the default relevance-based sorting is done by the server and matches the web.
kean
commented
Jun 26, 2025
| @@ -64,20 +62,6 @@ final class DomainSelectionViewController: CollapsableHeaderViewController { | |||
| table.reloadData() | |||
| } | |||
| } | |||
| private var _hasExactMatch: Bool = false | |||
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 28017 | |
| Version | PR #24631 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | bb29b06 | |
| Installation URL | 0luu1n413gamo |
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 28017 | |
| Version | PR #24631 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | bb29b06 | |
| Installation URL | 20jsp0e2sedl0 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://linear.app/a8c/issue/CMM-535/sometimes-domains-are-displayed-with-dashes