Fix false positive Keystone and WordPressData tests in CI #24630
Conversation
The only iOS version available out of the box with the 16.3 stack.
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 28042 | |
| Version | PR #24630 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 62c6317 | |
| Installation URL | 7f23vinvh7ir0 |
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 28042 | |
| Version | PR #24630 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 62c6317 | |
| Installation URL | 7e3v9si7ffa18 |
.buildkite/pipeline.yml
Outdated
| # Disabled till https://github.com/wordpress-mobile/WordPress-iOS/pull/24537 is completed | ||
| if: false |
There was a problem hiding this comment.
Mmm... this syntax didn't achieve the result I hoped
|
| # | ||
| # The boolean value has to be a string explicitly. | ||
| # See validation error against schema. | ||
| if: "false" |
There was a problem hiding this comment.
Notice the step for Keystone Tsets is no longer there
| @@ -0,0 +1,17 @@ | |||
| #!/bin/bash -euo pipefail | |||
There was a problem hiding this comment.
Might be worth extracting that on its dedicated set -euo pipefail line just to be sure.
This is because I think that if the command in the pipeline is a single string to a script with no parameter—and not a multiline string invoking multiple commands or a string invoking a command with parameters—then Buildkite might source that script (which makes the shebang ignored) instead of calling it as a command.
This is not the case currently because while the command: is now single line, it still passes a parameter to the script, so Buildkite with still call it not source it.
But in case in the future we end up not needing that parameter anymore and remove it and this ends up having the obscure side-effect of having the script sourced … better safe than sorry?
The tests for Keystone and WordPressData used
| xcbeautifybut withoutset -o pipefail, meaning that if the test failed, the error would have been swallowed by the pipe. Example:Case in point, this build where we can now see Keystone failing.
This PR addresses that. It also disables the Keystone tests from CI. Until the work in #24537 is completed, there's no point running them only to see them fail to build.