Cleanup Keystone and WordPressData Objective-C import #24628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 28044 | |
| Version | PR #24628 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 5ad3fbd | |
| Installation URL | 3ojhhtvipn5co |
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 28044 | |
| Version | PR #24628 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 5ad3fbd | |
| Installation URL | 7mq4nv2l93i1g |
Base automatically changed from
mokagio/add-some-imports-for-keystone-20250626
to
trunk
June 27, 2025 00:54
Just trying to understand why Keystone fails to build for testing. Using forward declarations keeps the headers and the compilation leaner.
Clearly the issues documented in some of the usages were temporary due to the transition.
mokagio
force-pushed
the
mokagio/cleanup-20250626-objc-imports
branch
from
d5a3720 to
5ad3fbd
Compare
|
kean
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my effort to get Keystone to build for testing (Keystone scheme > Shift Cmd U) I'm running into weird build failures.
One of the things I've done to try and wrangle them is to tidy up the Objective-C imports for Keystone and WordPressData.
This PR:
@import WordPressData#ifdef KEYSTONE. Notice that the custom build setting had removed weeks ago via 216b4c6