-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Feature: Post Settings #24623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kean
wants to merge
82
commits into
trunk
Choose a base branch
from
feature/post-settings
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature: Post Settings #24623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
App Name | WordPress | |
Configuration | Release-Alpha | |
Build Number | 28083 | |
Version | PR #24623 | |
Bundle ID | org.wordpress.alpha | |
Commit | aa03dc6 | |
Installation URL | 4134cfnflde2g |
|
App Name | Jetpack | |
Configuration | Release-Alpha | |
Build Number | 28083 | |
Version | PR #24623 | |
Bundle ID | com.jetpack.alpha | |
Commit | aa03dc6 | |
Installation URL | 38ii3bijo2nn8 |
c583d5a
to
0e2ecc0
Compare
…t is not editable
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project: https://linear.app/a8c/project/form-design-post-settings-c3b06a84aa38/
Note: "Status" field coming later.
Overview
Introduce a new "Post Settings" screen written in SwiftUI. The new implementation is easier to reason about thanks to the use of value types instead of Core Data objects. SwiftUI makes it extremely easy to add new rows or modify existing ones, which I use to make some minor enhancements like showing the author profile picture, and more. In the upcoming weeks, it will make it easy to integrate LLM-based features and nice animations on this screen.
Components:
PostSettings
– a plain struct to represent the settings edited on this screen (Equatable
to make it easy to check if there are any unsaved changes). More details in #24622.PostSettingsViewModel
– the settings screen where everything used to be in a ViewController now has a dedicated ViewModelPull Requests
Groundwork
Features
Removals
Social Sharing
I've looked into the "Social Sharing" in "Post Settings" and created a prototype to re-implement it in Swift. But during testing, I noticed that section was part of the "Prepublishing" sheet on the web and was missing from "Post Settings". The app shows this section in both "Post Settings" and "Prepublishing" sheet. I checked the analytics, and confirmed there are few people how do that to begin with, so it looks like a good call to simply remove this option for consistency with the web and simplicity, so we don't have to support these two different use-cases.