Skip to content

Feature: Post Settings #24623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 82 commits into
base: trunk
Choose a base branch
from
Open

Feature: Post Settings #24623

wants to merge 82 commits into from

Conversation

kean
Copy link
Contributor

@kean kean commented Jun 25, 2025

Project: https://linear.app/a8c/project/form-design-post-settings-c3b06a84aa38/

Screenshot 2025-06-30 at 10 05 20 AM

Note: "Status" field coming later.

Overview

Introduce a new "Post Settings" screen written in SwiftUI. The new implementation is easier to reason about thanks to the use of value types instead of Core Data objects. SwiftUI makes it extremely easy to add new rows or modify existing ones, which I use to make some minor enhancements like showing the author profile picture, and more. In the upcoming weeks, it will make it easy to integrate LLM-based features and nice animations on this screen.

Components:

  • PostSettings – a plain struct to represent the settings edited on this screen (Equatable to make it easy to check if there are any unsaved changes). More details in #24622.
  • PostSettingsViewModel – the settings screen where everything used to be in a ViewController now has a dedicated ViewModel

Pull Requests

Groundwork

Features

Removals

Social Sharing

I've looked into the "Social Sharing" in "Post Settings" and created a prototype to re-implement it in Swift. But during testing, I noticed that section was part of the "Prepublishing" sheet on the web and was missing from "Post Settings". The app shows this section in both "Post Settings" and "Prepublishing" sheet. I checked the analytics, and confirmed there are few people how do that to begin with, so it looks like a good call to simply remove this option for consistency with the web and simplicity, so we don't have to support these two different use-cases.

@kean kean added this to the 26.0 milestone Jun 25, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Jun 25, 2025

2 Warnings
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️ This PR is assigned to the milestone 26.0. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 25, 2025

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number28083
VersionPR #24623
Bundle IDorg.wordpress.alpha
Commitaa03dc6
Installation URL4134cfnflde2g
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 25, 2025

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number28083
VersionPR #24623
Bundle IDcom.jetpack.alpha
Commitaa03dc6
Installation URL38ii3bijo2nn8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@kean kean force-pushed the feature/post-settings branch from c583d5a to 0e2ecc0 Compare June 26, 2025 14:11
@kean kean requested a review from crazytonyli June 30, 2025 16:50
@kean kean marked this pull request as ready for review June 30, 2025 16:50
@kean kean requested a review from a team as a code owner June 30, 2025 16:50
Copy link

sonarqubecloud bot commented Jul 1, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants