Skip to content

Remove workspace file #24534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 23 commits into
base: trunk
Choose a base branch
from
Draft

Remove workspace file #24534

wants to merge 23 commits into from

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented May 9, 2025

Caution

This is still WIP and is not as straightforward as one might thing because we also need to change the path of the project file itself, which requires various path updates.

Description

See https://linear.app/a8c/issue/CMM-340

Testing instructions

mokagio added 23 commits May 9, 2025 11:20
Given OCLint is something we should drop soon, because it's only for
Objective-C and we want to reduce that code surface.
Locking dependencies to commits makes updating them a bit more
burdensome, but at least it makes the update intentional and not
automatic and surprising.

This change was done to test Xcode's behavior in monitoring
`Modules/Package.swift` and updating `Modules/Package.resolved`.

See
#24518 (comment)
@dangermattic
Copy link
Collaborator

2 Warnings
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

Copy link

sonarqubecloud bot commented May 9, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants