On this day game code structure refactor #5740
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cooltey
reviewed
Jul 2, 2025
app/src/main/java/org/wikipedia/games/onthisday/OnThisDayGameActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/wikipedia/games/onthisday/OnThisDayGameMenuFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/wikipedia/games/onthisday/OnThisDayGameOverFragment.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
The gameplay logic is moved out of OnThisDayGameActivity into its own fragment called OnThisDayGamePlayFragment. The onboarding fragment now acts as the menu. It shows the user the current state of the game and handles navigation from there. So instead of updating the state for navigation, the logic now directly navigates the user to the fragment. Also, OnThisDayGameOnboardingFragment is now called OnThisDayGameMenuFragment, and OnThisDayFinalFragment has been renamed to OnThisDayGameOverFragment.
Note: All game logic remains the same.