Right to Left testing for Year In Review Compose screens - T392741 #5516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge latest changes from main into yearInReview_design
* update dependencies, manifest. Add yearinreview package with navigation and test screen * fix linting errors * fix remaining linting error * removed 'exported' attribute and added BaseTheme to the NavHost testscreen
… (#5385) * Created ClickListner for 'Year in Review' selection and linked to YearInReviewActivity * modified newIntent and yearInReviewClick() to remove the userName as a parameter
* WIP: current changes, removed unecessary file changes * add string resources and modify colors * added wikithemes modified scrolling behavior * remove unecessary implementations for Gifs * add strings to values-qq folder, added Wikitheme typography * adding libs folder * correcting linting errors * fixing additional linting errors * added base theme for preview rendering * fix linting errors * added screen date, gifs, strings and navigation for scaffold and navhost * Delete app/src/main/java/org/wikipedia/yearinreview/testCode2.kt This file is not needed for the repo and is being removed. * fixing linting errors * fixing remaining linting errors * correcting last linting error * replace icons, adjust composable tint & color, add gradle files * update icons, adjust composable themes, add gradle files * added navigation, re-organized YearInReviewActivity for readability * fix linting errors * removed unused depenency references in version catalog * changed gifResource to imageResource per feedback * separated the getstarted string name reference string an underscore * added underscore to string names with readcount and editcount * added format specifier %d to string resources & temporarly hardcoded scaffold with a value * replace TODO with Unit & GetStared Enum with Onboarding * changed YearInReviewScreenScaffold to YearInReviewScreen * removed fetchedData property from YearInReviewScreenData * moved scrollState to YearInReviewScreen function * moved pagerState from activity to YearInReviewScreen composable * clean up linting errors, rename GetStartedBottomBar to OnboardingBottomBar * refactored use scrollstate only in the YearInReviewScreenContent composable * correct linting errors * added %d references for qq-strings * remove redundant string names in values-qq
Follow up: Year-in-review code format optimization
) * added dot pagination with contraint layout, changed TODO's, added pages to test size gradient * fix linting errors * populated NavHost properties to remove default nav transitions * refactor paginationSizeGradient, modified BottomAppBar for top border only * added comment for test screens, updated parameter naming * added animation for smoothness, update variable naming for clarity * removed drawline and added HorizontalDivider
Follow-up: YiR pagination and code formats update
…path - T390121 (#5465) * added explore screen, added navigation to YearInReviewActivity * add strings, route back to explore screen from onboarding screen * added button text string resource, minor formatting changes * address context in ImageView with 'it' and 'this' * remove padding constants and xml binding * Removed 'Scaffold' from 'YearInReviewBottomSheetScaffold' * added scrollstate YearInReviewBottomSheet to handle screen rotation * Moved ExclusiveBottomSheetPresenter for the Explore Screen to MainFragment * correct linting --------- Co-authored-by: cooltey <coolteygame@gmail.com>
Follow-up: YiR entry dialog code optimization
* added dot pagination with contraint layout, changed TODO's, added pages to test size gradient * fix linting errors * populated NavHost properties to remove default nav transitions * refactor paginationSizeGradient, modified BottomAppBar for top border only * added comment for test screens, updated parameter naming * added animation for smoothness, update variable naming for clarity * removed drawline and added HorizontalDivider * added api & db calls, viewmodel, updated strings * remove accidentally duplicated qq-strings after merge * add gif assets for collective slides * add non-english collective slide text * added nonEnglish collective data and fetchedargs property * optimize DB query, implment Resource class with screen List * remove commented code in test screen and unused data class * add qq-strings for non-english collective screens * add application context to viewmodel and reorganized string formatting * removed unecessary parameters from getUserContribsByTimeFrame API call * renamed query, adjusted query for displayTitles * remove factory class, rework viewmodel instatiation, add WikipediaApp instance * simplified getDisplayTitles query, moved span tag extraction to viewModel * created LoadingIndicator composable and added to YearInReviewActivity * Adapt API calls for LocalDateTime * clean up linting errors * refactored to convert start & end times to be of type Instant * Add WikiErrorView * removed unused error branch in YearInReviewActivity * fixing linting error
Follow-up: viewModel for YearInReview
* integrate DonateDialog class into YiR donate button * removed casting and replaced with instance reference of the class * refactored to not pass class instance for Donate functionality * re-organized MainBottomBar parameters
voyagerfan
added
WIP
* add breadcrumb and donation tracking * add imports for breadcrumb and donation * add placeholder for campaignId * removed duplicate clickable * added ripple animation to clickable donate row * changed campainId to 'yir' * Add function invocation for onDonateClick * moved instrumentation calls to lambda in YearInReviewActivity
…5048 (#5588) * replaced instances of AndroidView with AsyncImage Composable * removed context unused context variable * add strings for AsyncImage content description * add positions for strings with multiple format specifiers * removed unecessary backslashes * replaced %s values with percent %d where appropriate * add plurals and modidfy viewModel to use plurals * added minimum edit count conditional for personalized screen to mimic ios version
…394815 (#5579) * remove info icon from onboarding screen, adding MediaWiki links * add media wiki url to the strings folder * add string resources to UI, removed apostrophe from qq-strings * remove replace child composable context with activity context * fix linting error * move mediawiki link to strings_no_transalte and remove everywhere else * removed pagerState from onboarding composable route
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This implements RTL testing for Year in Review screens
Why is this needed?
To ensure that RTL languages render properly when the language settings are changed.
Phabricator:
https://phabricator.wikimedia.org/T392741