UI Changes #2
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,4 +1,4 @@ | ||||||
| import React, {Fragment, useEffect, useState, useCallback, useRef} from 'react'; | ||||||
| import {shallowEqual, useDispatch, useSelector} from 'react-redux'; | ||||||
| import Form from 'react-bootstrap/Form'; | ||||||
| import Button from 'react-bootstrap/Button'; | ||||||
|
|
@@ -7,7 +7,7 @@ import Spinner from 'react-bootstrap/Spinner'; | |||||
| import {SlideDown} from 'react-slidedown' | ||||||
| import 'react-slidedown/lib/slidedown.css' | ||||||
| import {callStatus, dial, dtmf, getAccounts, getSoftphoneStatus, hangUp, hold, loginSync, logout, unHold, updateCallStatus} from './actions'; | ||||||
| import {ToastContainer, Bounce} from 'react-toastify'; | ||||||
| import logo from './logo.png'; | ||||||
| import {CALL_TERMINATE, CONFIRMED, DISCONNECTED, LOADER, EARLY, LOCAL_HOLD} from './constant'; | ||||||
| import './App.css'; | ||||||
|
|
@@ -136,6 +136,8 @@ function WSEventStream() { | |||||
| function Dialer() { | ||||||
| const dispatch = useDispatch(); | ||||||
| const loading = useSelector(state => state.loading, shallowEqual); | ||||||
| const inputRef = useRef(null); | ||||||
|
|
||||||
|
Comment on lines
+139
to
+140
There was a problem hiding this comment. Input reference created but not attached to any element The inputRef is created but never attached to an input element. This will cause the useEffect hook that uses this reference to not work as expected. You need to attach the ref to the input element on line 280: -<SlideDown><form><input type="display" value={phoneNumber} onChange={(ev) => setPhoneNumber(ev.target.value)}/></form></SlideDown>
+<SlideDown><form><input ref={inputRef} type="display" value={phoneNumber} onChange={(ev) => setPhoneNumber(ev.target.value)}/></form></SlideDown>📝 Committable suggestion
Suggested change
|
||||||
| const [phoneNumber, setPhoneNumber] = useState(""); | ||||||
| const isCallDialed = useSelector(state => state.callDialed, shallowEqual); | ||||||
| const accountName = useSelector(state => state.accountName, shallowEqual); | ||||||
|
|
@@ -156,7 +158,9 @@ function Dialer() { | |||||
| } | ||||||
|
|
||||||
| function clear() { | ||||||
| if (phoneNumber.length > 0) { | ||||||
| setPhoneNumber(phoneNumber.slice(0, -1)); | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| const dialNumber = () => { | ||||||
|
|
@@ -236,6 +240,22 @@ function Dialer() { | |||||
| return () => clearInterval(interval); | ||||||
| }, [isCallDialed]); | ||||||
|
|
||||||
| useEffect(() => { | ||||||
| if (inputRef.current) { | ||||||
| const input = inputRef.current; | ||||||
|
|
||||||
| if (input.scrollWidth > input.clientWidth) { | ||||||
| input.classList.add('overflowing'); | ||||||
| input.scrollLeft = input.scrollWidth; | ||||||
| } else { | ||||||
| input.classList.remove('overflowing'); | ||||||
| } | ||||||
| } | ||||||
| }, [phoneNumber]); | ||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
| return ( | ||||||
| <div className="dialer"> | ||||||
| <WSEventStream/> | ||||||
|
|
@@ -256,7 +276,7 @@ function Dialer() { | |||||
| </div> | ||||||
| ))} | ||||||
|
|
||||||
| <SlideDown><form><input type="display" value={phoneNumber} onChange={(ev) => setPhoneNumber(ev.target.value)}/></form></SlideDown> | ||||||
|
|
||||||
| {loading && | ||||||
|
|
@@ -339,7 +359,19 @@ function App() { | |||||
| },[dispatch]) | ||||||
| return ( | ||||||
| <Fragment> | ||||||
| <ToastContainer | ||||||
| position="top-right" | ||||||
| autoClose={5000} | ||||||
| hideProgressBar={false} | ||||||
| newestOnTop={false} | ||||||
| closeOnClick={false} | ||||||
| rtl={false} | ||||||
| pauseOnFocusLoss | ||||||
| draggable | ||||||
| pauseOnHover | ||||||
| theme="light" | ||||||
| transition={Bounce} | ||||||
| /> | ||||||
| <header-nav> | ||||||
| <nav className="navbar" style={{backgroundColor: "rgb(40, 116, 240)"}}> | ||||||
| <div className="navbar-logo"> | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Potential Contrast Issue with
.name: The.nameclass is set to usecolor: var(--surface), which is the same value used as the background color for the.logincontainer. This could lead to poor readability. Please confirm whether this was intentional or consider using a contrasting color (for example,var(--text-primary)).