Skip to content

feat: initFilter allows looking other file types, ignore other than /_. #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2025

Conversation

vic
Copy link
Owner

@vic vic commented Jul 1, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings July 1, 2025 19:43
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a customizable initial filter for import trees, adds a .files shorthand to retrieve filtered files directly, and updates tests and docs to use these new features.

  • Add initf parameter and initFilter API to override default file filter
  • Implement .files attribute as a shortcut for leafs.result
  • Update tests and README to cover initFilter and .files

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
default.nix Introduce initf, compute nixFilter, wire up initFilter and .files, remove old leafs.result usage
checkmate.nix Swap leafs.result to .files in tests, add tests for initFilter behavior
README.md Document new .initFilter and .files APIs, update usage examples
Comments suppressed due to low confidence (2)

default.nix:6

  • [nitpick] The parameter initf is ambiguous and doesn’t match the exported initFilter method; consider renaming it to initFilter for clarity and consistency.
      initf ? null,

default.nix:32

  • The variable treeFiles is introduced but never used; consider removing it to clean up dead code.
          treeFiles = t: (t.withLib lib).files;

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@vic vic merged commit 21c639d into main Jul 1, 2025
1 check passed
@vic vic deleted the vic/jj-change-mymqswuwsroo branch July 1, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant