remove default from non-optional arguments. #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates default.nix by removing default values for certain function parameters, thereby making them required.
- Dropped defaults for
filterfandmapf - Removed default empty list for
paths - Retained default for
pipef
Comments suppressed due to low confidence (4)
default.nix:6
- Removed default for
filterfmakes this parameter required; please update documentation and usage examples to reflect this breaking change.
filterf,
default.nix:7
- Removed default for
mapfmakes this parameter required; please update documentation and usage examples to reflect this breaking change.
mapf,
default.nix:8
- Removed default for
pathsmakes this parameter required; ensure callers provide this argument and update any documentation accordingly.
paths,
default.nix:2
- Making these parameters mandatory may break existing usage; add or update tests to cover both presence and absence of
filterf,mapf, andpathsto catch regressions.
perform =
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.