Skip to content

fix: better dark/light support on unauthenticated #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpvalery
Copy link
Contributor

@jpvalery jpvalery commented Jun 4, 2025

Description

The toggle on (unauthenticated) layout was disappearing when switching—this change prevents that

Checklist

  • My code follows the code style of this project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation, if necessary.
  • I have added tests that prove my fix is effective or my feature works.
  • New and existing tests pass locally with my changes.

Screenshots (if applicable)

Before

CleanShot 2025-06-04 at 16 53 46

After

(do note that in my own version I have a different method for ModeToggle that switches between the theme rather than displaying a dropdown).

CleanShot 2025-06-04 at 16 54 38

Copy link

vercel bot commented Jun 4, 2025

@jpvalery is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@QuentinFrc QuentinFrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternative is to override color for toggle on light theme but think your solution is the best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants