fix: knock provider theme #566
Open
+114
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jpvalery is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
QuentinFrc
suggested changes
Jun 10, 2025
Can you share a snippet of what you would do? I'm not sure to follow? |
QuentinFrc
reviewed
Jun 12, 2025
Comment on lines
+24
to
+25
| const { theme: rawTheme } = useTheme(); | ||
| const theme = rawTheme === 'dark' ? 'dark' : 'light'; |
There was a problem hiding this comment.
const { resolvedTheme } = useTheme(); // Returns same as theme value but resolve system to the corresponding valueuseTheme in next-themes api doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This improves the KnockProvider to follow the theme
Checklist
Screenshots (if applicable)