Skip to content

chore: update default module resolution to bundler #6430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

likui628
Copy link
Collaborator

@likui628 likui628 commented Jun 25, 2025

Description

closes #6359

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
  • Run the tests with pnpm test.
  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

  • Chores
    • Updated TypeScript configuration to use bundler-style module resolution.
    • Removed an unused TypeScript directive comment from internal configuration.

Copy link

changeset-bot bot commented Jun 25, 2025

⚠️ No Changeset found

Latest commit: 64d399f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Jun 25, 2025

Walkthrough

This change removes a TypeScript error suppression comment from command.ts and updates the TypeScript configuration in base.json to use "bundler" for moduleResolution instead of "node". No other logic or configuration options are altered.

Changes

File(s) Change Summary
internal/lint-configs/eslint-config/src/configs/command.ts Removed a TypeScript error suppression comment from object spread.
internal/tsconfig/base.json Changed moduleResolution from "node" to "bundler".

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant TypeScript Compiler

    Developer->>TypeScript Compiler: Compile project with updated tsconfig
    TypeScript Compiler-->>Developer: Resolve modules using "bundler" strategy
Loading

Assessment against linked issues

Objective Addressed Explanation
Fix import error in internal/lint-configs/eslint-config/src/configs/command.ts (#6359)

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes found.

Possibly related PRs

  • fix: tsconfig moduleResolution #6122: Both PRs modify TypeScript configuration files to set the moduleResolution option to "bundler", directly relating their changes at the configuration level.

Poem

A bunny with lint in its fur,
Tweaked configs to make things occur.
With "bundler" in place,
And comments erased,
Now TypeScript will purr, not demur! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2f7d1f0 and 64d399f.

📒 Files selected for processing (2)
  • internal/lint-configs/eslint-config/src/configs/command.ts (0 hunks)
  • internal/tsconfig/base.json (1 hunks)
💤 Files with no reviewable changes (1)
  • internal/lint-configs/eslint-config/src/configs/command.ts
⏰ Context from checks skipped due to timeout of 90000ms (9)
  • GitHub Check: Lint (ubuntu-latest)
  • GitHub Check: Test (windows-latest)
  • GitHub Check: Lint (windows-latest)
  • GitHub Check: Test (ubuntu-latest)
  • GitHub Check: Check (windows-latest)
  • GitHub Check: Check (ubuntu-latest)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: post-update (ubuntu-latest)
  • GitHub Check: post-update (windows-latest)
🔇 Additional comments (1)
internal/tsconfig/base.json (1)

14-14: ```shell
#!/usr/bin/env bash

List TypeScript versions across all package.json files

fd --type f -e json package.json | xargs -I{} sh -c '
echo -n "{}: ";
jq -r ".dependencies.typescript // .devDependencies.typescript // "N/A"" {}
' | sort

Inspect Dockerfiles for explicit TypeScript installs

fd --type f -g "Dockerfile*" | xargs -I{} grep -Hn "npm install.*typescript" {} || echo "No explicit TS install found in Dockerfiles"


</details>

</blockquote></details>

</details>
<!-- internal state start -->


<!-- DwQgtGAEAqAWCWBnSTIEMB26CuAXA9mAOYCmGJATmriQCaQDG+Ats2bgFyQAOFk+AIwBWJBrngA3EsgEBPRvlqU0AgfFwA6NPEgQAfACgjoCEYDEZyAAUASpETZWaCrKNwSPbABsvkCiQBHbGlcSHFcLzpIACIGWHx/LmxuWmoPJQAzNG9Q5kVvD39EfC88eHwsAkgAAwFsDFpIimroyAB3NGQHAWZ1Gno5SGxESkgveABrbHgANgAmAA50ZFtIDEcBUZmAFgBmAAZ+StgPCWCwCU2MMDRaXqx/bnxEdQTZDRgTxlhMUnRaWhFEbIJAODxmGa7ACsAE50A0UMgGF5Oi8MvAop10JA6kRIOiAB5hH6hWj4aRrfCheAYXAUfIMDwCfxoCY0vFxX7SD7uIYpNKQPK0eDoim4L6ZbJeXL5SJ+aQlMoVex0tJEeRVYYeWr1RqUao8r6rJSIBgUeDccTKmnI7Am7FxUQTcaIUL+DKUMgMdnEjy8fAiMQAciRFTp8DqVqwRGmSnG5EQABocXhKf9hVG0L4yQxHOxqOUMMmaK6k/w+JyMKQvPg8clUiX0P4UA14Aw0vQsdxnKF8Bliahur1EC8KoaPKttMxkFV4Mx/VJfYLZYUFaUoziSD8JOU+G11PFU1maOaq5ASASkOIzxl6mJC1n1PIEvKgvBT3ic3naQXlZXSIgGhGPoxjgFAZD0H2OAEMQZDKP0CisOwXC8PwwiiOIUgyPITBKFQqjqFoOggSYUBwKgqCYNBhCkOQVAIUwSG0lwVBtPYjjMM48iDLhygEZo2i6GAhigaYBg0ieGBZgA9PGuBgEwGDokQiDSdIckKRUynSYgFAMNJinKapjGcQ0Gi4IgHAGNENkGBYkAAIIAJKwXRHbsU4Lj8P2/7SG4Xy+fKeRYdiLxVnKJnsGMNIeIpuDaBgPpoDAsjcCQADKZoWqS74YZI2rSdJkAAAIWWAF5pWI5UUPSfBQBg+BhKl0jVPi9LMEugiBqEiC8CQtzeUu1Rmv1NAAMIsKZtAABQAJStUUOQti8ShDSZmC0K1nSyBgDD4neUYfAAco1VInBWigeC+NZEG2iLoNKnq0EBRh2ZYDmPfRhYzo14rpKIKJfRUyBQRVCQIS+3DYAI4x7ew6gYogRgneQQE2dEwFiRJlBSV40kWYZ8BENJAidCQGhCMUGBWejb2OS5tHwVEDiec+Pk/FWfkGLy0DNZl5qWgoSlE9gQNYDSNTYxQuP46aWlEyTZMU1TrUdMgQoihiAw4Rzt1nn9NRCgUNhrkqGCtYx3DwE0/CWoWbUsDU0QNUo0StVULR1A0TRu4alGfcg8RsUbcq9aImuUMgzirsUXhSPQtCiz6lvW7+Rb2PuuBxD6GTtZAJ1KMrYCurIcpFIqG5VMlXt6hQxe4KXMcV/brr0SQ6rHadf0XfO1ujPgdvA+W9gkLg14qe0nrfFyz2vXTH0nmnP1LkoyLOEvg1gxQEN8FDMN3fD4hcyj5PWbZBggQYpHngiUHZDBjNt/QkXMX4aBsSznFeTxl34WoAnEWElfMCiFei4AAPrwFoIgcB/gdwkDaHQcBroexCREtfHYtBdgwhhBkWgMJUjzBIAILBaASALAAIwCAYDMChFC5jbAyNsChuxoTbAAOwkAyBkJYl9r4mXUJA6BsCSDwMQbQcBEE0FAA= -->

<!-- internal state end -->
<!-- finishing_touch_checkbox_start -->

<details open="true">
<summary>✨ Finishing Touches</summary>

- [ ] <!-- {"checkboxId": "7962f53c-55bc-4827-bfbf-6a18da830691"} --> 📝 Generate Docstrings

</details>

<!-- finishing_touch_checkbox_end -->
<!-- tips_start -->

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

<details>
<summary>❤️ Share</summary>

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)
- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)
- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)
- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

</details>

<details>
<summary>🪧 Tips</summary>

### Chat

There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=vbenjs/vue-vben-admin&utm_content=6430):

- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  - `I pushed a fix in commit <commit_id>, please review it.`
  - `Explain this complex logic.`
  - `Open a follow-up GitHub issue for this discussion.`
- Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples:
  - `@coderabbitai explain this code block.`
  -	`@coderabbitai modularize this function.`
- PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.`
  - `@coderabbitai read src/utils.ts and explain its main purpose.`
  - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.`
  - `@coderabbitai help me debug CodeRabbit configuration file.`

### Support

Need help? Create a ticket on our [support page](https://www.coderabbit.ai/contact-us/support) for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

### CodeRabbit Commands (Invoked using PR comments)

- `@coderabbitai pause` to pause the reviews on a PR.
- `@coderabbitai resume` to resume the paused reviews.
- `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
- `@coderabbitai full review` to do a full review from scratch and review all the files again.
- `@coderabbitai summary` to regenerate the summary of the PR.
- `@coderabbitai generate docstrings` to [generate docstrings](https://docs.coderabbit.ai/finishing-touches/docstrings) for this PR.
- `@coderabbitai generate sequence diagram` to generate a sequence diagram of the changes in this PR.
- `@coderabbitai resolve` resolve all the CodeRabbit review comments.
- `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository.
- `@coderabbitai help` to get help.

### Other keywords and placeholders

- Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed.
- Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description.
- Add `@coderabbitai` anywhere in the PR title to generate the title automatically.

### CodeRabbit Configuration File (`.coderabbit.yaml`)

- You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository.
- Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json`

### Documentation and Community

- Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit.
- Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback.
- Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

</details>

<!-- tips_end -->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: 文件报错command.ts
1 participant