fix(@vben/common-ui): add page footer's height to calc contentstyle

[aha-weikai]

Summary by CodeRabbit

• Bug Fixes
  • Improved content area sizing so that it now correctly accounts for both the header and footer heights, ensuring consistent layout when automatic content height adjustment is enabled.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 191dd3b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The calculation for the content area's height in the Page component was updated to subtract both the header and footer heights, in addition to an existing configurable offset, from the total layout content height. This ensures the content area accurately reflects available space when both header and footer are present.

Changes

File(s)	Change Summary
packages/effects/common-ui/src/components/page/page.vue	Modified content height calculation in the contentStyle computed property to also subtract footer height.

Sequence Diagram(s)

sequenceDiagram
    participant Layout
    participant PageComponent
    participant Header
    participant Footer

    Layout->>PageComponent: Render with autoContentHeight enabled
    PageComponent->>Header: Get header height
    PageComponent->>Footer: Get footer height
    PageComponent->>PageComponent: Compute content height = layoutContentHeight - headerHeight - footerHeight - offset
    PageComponent-->>Layout: Render content area with computed height

Loading

Possibly related PRs

• perf: page componet supports custom height offset for flexible content height … #6081: Both PRs modify the content height calculation in the Page component, focusing on adjusting how the height is computed for accurate layout.

Suggested reviewers

• mynetfan
• anncwb
• vince292007

Poem

The header and footer now both have their say,
In shaping the space where content will play.
With heights subtracted, the math is just right,
The page looks perfect, both day and night.
🐇✨
— A rabbit who loves tidy heights

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 986eaca and 191dd3b.

📒 Files selected for processing (1)

• packages/effects/common-ui/src/components/page/page.vue (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: post-update (windows-latest)
• GitHub Check: post-update (ubuntu-latest)

🔇 Additional comments (1)

packages/effects/common-ui/src/components/page/page.vue (1)

28-28: LGTM! Proper fix for content height calculation with footer.

This change correctly addresses the layout issue by including the footer height in the content area calculation. Since the footer is absolutely positioned at the bottom, the content area needs to account for its height to prevent overlap. The implementation properly subtracts all three components (header, footer, and offset) from the available layout height.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.