-
Notifications
You must be signed in to change notification settings - Fork 43
Laravel7 compatibility #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @lenssoft Unfortunately, I am not maintaining this module actively anymore. Would you be willing to take it over? |
If i am going to use it in production then I will be able to take over. Until then I can use my forked repo with the compatibility fix. |
ok let me know. |
Hi @mruoss |
Done. Let me know your packagist username if you want to deploy there. |
My packagist username is lenssoft |
Also by the way, it seems like this project was forked and re-published already: https://github.com/highsolutions/laravel-lang-import-export |
good to know |
Yeah, since I was not maintaining it, this makes sense. It is also has more downloads than my original one and is maintained. So feel free to re-create a pull request also on their side and maybe at some point we can close this project. Up to you. |
I guess you closed this in favor for highsolutions#10? |
I closed this in favour of #6 |
I see. Thanks. |
This PR adds compatibility to laravel ^7 (probably earlier versions too).
@mruoss could you make a new version tag (e.g. 7.0.0) out of this changes and possibly update the README about which versions to include based on laravel version.