Skip to content

Laravel7 compatibility #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Laravel7 compatibility #5

wants to merge 5 commits into from

Conversation

lenssoft
Copy link
Contributor

This PR adds compatibility to laravel ^7 (probably earlier versions too).

@mruoss could you make a new version tag (e.g. 7.0.0) out of this changes and possibly update the README about which versions to include based on laravel version.

@mruoss
Copy link

mruoss commented May 26, 2020

Hi @lenssoft

Unfortunately, I am not maintaining this module actively anymore. Would you be willing to take it over?

@lenssoft
Copy link
Contributor Author

If i am going to use it in production then I will be able to take over. Until then I can use my forked repo with the compatibility fix.

@mruoss
Copy link

mruoss commented May 26, 2020

ok let me know.

@lenssoft
Copy link
Contributor Author

lenssoft commented Jun 1, 2020

Hi @mruoss
We decided to use this package in production. Could you add me as a maintainer to the repo?

@mruoss
Copy link

mruoss commented Jun 2, 2020

Done. Let me know your packagist username if you want to deploy there.

@lenssoft
Copy link
Contributor Author

lenssoft commented Jun 2, 2020

My packagist username is lenssoft

@mruoss
Copy link

mruoss commented Jun 2, 2020

Also by the way, it seems like this project was forked and re-published already: https://github.com/highsolutions/laravel-lang-import-export

@lenssoft
Copy link
Contributor Author

lenssoft commented Jun 2, 2020

good to know

@mruoss
Copy link

mruoss commented Jun 2, 2020

Yeah, since I was not maintaining it, this makes sense. It is also has more downloads than my original one and is maintained. So feel free to re-create a pull request also on their side and maybe at some point we can close this project. Up to you.

@lenssoft lenssoft closed this Jun 4, 2020
@mruoss
Copy link

mruoss commented Jun 4, 2020

I guess you closed this in favor for highsolutions#10?

@lenssoft
Copy link
Contributor Author

lenssoft commented Jun 4, 2020

I closed this in favour of #6

@mruoss
Copy link

mruoss commented Jun 4, 2020

I see. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants